fix(tool): handle undefined input while streaming - #491
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
Contributor
|
@minwookshin is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #490.
Initial
input-streaminginput can beundefined, which makesJSON.stringifyreturnundefinedand crashesCodeBlockatcode.split. ReturnnullfromToolInputuntil input exists so the surrounding tool stays visible. Preserve JSON rendering for defined values, includingnull,false,0, an empty string, and an empty object.Add eight regression cases covering missing input, partial-to-available input, clearing previous parameters, and defined falsy values. Update the example and prop documentation to show the initial streaming state. No public API changes.
Validation:
code.splitcrash in Chromium before applying the fix.pnpm build --filter ai-elements --filter docs.Repository-wide checks have existing limitations:
pnpm checkflags nine untouched files; the Ultracite lint invocation fails to resolveimport/no-unresolved. Standalone elements TypeScript checking reports the same 57 diagnostics with both HEAD and this patch, with none in changed files. The documentation preview also emits a React hydration warning on both Tool and the untouched Suggestion page.