Resolve skills from split npm package installs - #405
Merged
Conversation
Co-authored-by: fx89757 <165190761+fx89757@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Railly
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NATIVE_SDK_SKILLS_ROOTfirst, thenNATIVE_SDK_PATH, while falling through empty or invalid candidates.@native-sdk/clipackage, covering checkout, flat bundle, hoisted, and nested optional-dependency layouts.test-skills-cli.Why
Platform-specific npm packages can own the Native SDK executable while the main CLI package owns the bundled skills. The previous ancestor-only lookup could not find that sibling payload, so normal split-package installs failed to discover skills. This keeps the payload in the main package while allowing the platform executable to resolve it reliably.
Closes #404