Skip to content

fix(runtime): apply TypeScript core external_links policy #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yusufesse wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(runtime): apply TypeScript core external_links policy #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions src/app_runner/ts_core_main.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
//! scene / canvas app.zon's `.shell` through `shellConfigFrom`; the
//! canvas is the scene's first gpu_surface view.
//! identity app.zon's `.id`/`.name`/`.display_name`.
//! security app.zon's `.permissions` and navigation origins.
//! security app.zon's `.permissions`, navigation origins, and
//! `external_links` (Cmd.openExternalUrl allowlist).
//! theme app.zon's `.theme` pack; the stock tokens compose
//! it with the live system appearance. `.theme_accent`
//! layers the manifest's one-accent brand override
Expand Down Expand Up @@ -83,6 +84,7 @@ pub const app_markup = @embedFile("app.native");

const app_permissions = manifestStringList(manifest, "permissions");
const allowed_origins = manifestAllowedOrigins();
const external_links = manifestExternalLinks();
const app_data_dir_env = "NATIVE_SDK_APP_DATA_DIR";

pub fn main(init: std.process.Init) !void {
Expand Down Expand Up @@ -312,7 +314,10 @@ pub fn main(init: std.process.Init) !void {
.js_window_api = false,
.security = .{
.permissions = app_permissions,
.navigation = .{ .allowed_origins = allowed_origins },
.navigation = .{
.allowed_origins = allowed_origins,
.external_links = external_links,
},
},
.relational_migrations = &relational_migrations.migrations,
}, init);
Expand Down Expand Up @@ -504,3 +509,26 @@ fn manifestAllowedOrigins() []const []const u8 {
return manifestStringList(manifest.security.navigation, "allowed_origins");
}
}

fn manifestExternalLinks() native_sdk.security.ExternalLinkPolicy {
comptime {
if (!@hasField(@TypeOf(manifest), "security")) return .{};
if (!@hasField(@TypeOf(manifest.security), "navigation")) return .{};
if (!@hasField(@TypeOf(manifest.security.navigation), "external_links")) return .{};
const links = manifest.security.navigation.external_links;
return .{
.action = manifestExternalLinkAction(links),
.allowed_urls = if (@hasField(@TypeOf(links), "allowed_urls"))
manifestStringList(links, "allowed_urls")
else
&.{},
};
}
}

fn manifestExternalLinkAction(comptime links: anytype) native_sdk.security.ExternalLinkAction {
if (!@hasField(@TypeOf(links), "action")) return .deny;
const action: []const u8 = links.action;
if (std.mem.eql(u8, action, "open_system_browser")) return .open_system_browser;
return .deny;
}