Repository navigation
pico2w: vendor CYW43 firmware blobs instead of absolute symlinks - #107
Merged
Merged
Conversation
The three files in cyw43-firmware/ were committed as symlinks into /home/vince/.cargo/git/checkouts/embassy-*/6b01532/, which only exists on one machine, so wifi/driver.rs failed to build via include_bytes! anywhere else. Replace them with the real blobs from the embassy rev pinned in Cargo.lock (c722d94) and add the Infineon Permissive Binary License they are distributed under. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 93.06% 92.82% -0.25%
==========================================
Files 83 83
Lines 14155 14155
==========================================
- Hits 13174 13139 -35
- Misses 981 1016 +35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
platform/pico2w/cyw43-firmware/{43439A0.bin, 43439A0_clm.bin, nvram_rp2040.bin}were committed as symlinks to/home/vince/.cargo/git/checkouts/embassy-*/6b01532/.... That path only exists on one machine, sowifi/driver.rsfailed to build (include_bytes!) everywhere else.Cargo.lock(c722d94).Testing
cargo build --releaseinplatform/pico2wsucceeds on a machine without the original author's cargo cache.6b01532revision.This is the base of a stack; the BSP refactor PR targets this branch.
🤖 Generated with Claude Code