Conversation
Select fixed declarations by transport capabilities instead of a Flash allowlist, retaining native anchored additions where Pi supports them. Keep execution activation private to Desktop so folding adapters do not rewrite their leading instructions after each search. Exercise all Desktop-selectable adapters through the runtime tool loop, with compatible-route HTTP and process coverage and independent activation restoration and permission checks.
The unflagged fixture now declares its catalog upfront. Assert persisted activation and stable request schemas instead of expecting a later declaration delta.
CI observed the readiness file between creation and its JSON write. Rename a completed sibling file into place so process cancellation assertions begin only after the PID list is readable.
Distinguish the pinned adapter behavior from the provider inline-tool beta. System-message and tool-reference capabilities cannot enable an unsupported wire format.
Keep verified Anthropic tool changes on their native append-only path now that Pi sends full definitions inline. System-only bindings still need a fixed catalog, and the request matrix covers both capability boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题与修改
#1355 合入了 #1325 较早的版本,固定工具清单仍只对官方 Flash 生效,遗漏了后续跨接口补丁。本 PR 补回这些提交,并对齐最新 main 的 Pi 1.0.1;不会重做已经合入的 system/Skill 持久化改动。
tool_activation元数据,防止折叠 system 的适配器因激活状态变化再次改写前缀;完整记录仍用于保存和恢复。验证
最终候选
6492b63aed71,基于3c2291bd1a0d。复用现有工作树开发环境和共享 Cargo target;main 升级 Pi 1.0.1 后按冻结锁文件增量更新现有依赖,没有另建测试环境。tool_definition。Claude Code review skill 的最终复审被
403 Insufficient account balance阻断,因此保留 draft,不声称最终候选已通过该复审。较早审查关于 Flash fixture 应使用 native 的疑虑不适用:Flash 本就应走固定清单;关于每次调用都重新搜索的建议也未采用,成功 ToolSearch 结果已经提供激活名称。这两点的最终 CC 复核仍待完成。远端 CI 的 JavaScript、Rust,以及独立 Docs、PR-base 四项检查均已通过。GitHub 合并候选
96ef3db7a53d与本地验证提交代码树一致。本 PR 保持 draft,未请求合并。离线适配器与本地 SSE 测试证明请求构造、执行和恢复流程,不证明服务端实际缓存命中率。本轮未调用付费模型。固定目录首轮成本、超限回退、工具目录变化,以及无中途 system 支持的真实 Skill 更新仍可能影响缓存。此前 DeepSeek 成本实验不是本轮跨模型验证,不能外推。
Related to #1285; follows up #1325 and #1355.