fix(project-groups): detach folders with chats safely - #1351
Merged
Merged
Conversation
Allow secondary group folders with existing chats to detach while preserving their standalone project projection. This removes the group-delete deadlock and keeps chat deletion as a separate explicit action.
Keep the Chinese E2E plan aligned with the new detach behavior and its English acceptance coverage so documentation validation sees matching locale structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow an additional folder with existing chats to be detached from a multi-folder project group. Its chats remain reachable through a standalone project, and deleting that project remains a separate explicit action that preserves the folder on disk.
Update the project-group and project-delete specs, E2E scenario, and all shipped locale descriptions.
Validation
pnpm check:pr-base— passed againste65975048CARGO_TARGET_DIR=/Users/lan/Project/opensource/PI-Desktop/target cargo test -p host-core --locked— 748 passedcargo clippy -p host-core --all-targets --locked— passedcargo fmt --check— passedpnpm --filter @pi-desktop/i18n test— 29 passednode --test apps/desktop/test/project-edit.test.mjs— 6 passedPI_DESKTOP_ELECTRON_BIN=/tmp/pi-desktop-electron-headless node scripts/e2e-project-edit.mjs— passed