add responsibility to change callback field name in js#19
Merged
Conversation
echerniak
reviewed
Mar 27, 2026
echerniak
left a comment
echerniak
left a comment
There was a problem hiding this comment.
Надо еще кажется версию самого трифта бампнуть, посмотри по предыдущим пр
echerniak
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Причина изменений:
При наличии в перечне методов из протокола thrift аргументов с именем callback ловим ошибку при генерации кода на JS . Все из-за того что JS добавляет специальный параметр callback в список аргументов. Получается ошибка
Предлагается изменение названия параметра callback при совпадении с именем одного из параметров метода. По аналогии с params