Repository navigation
feat: add optional nohz_full GRUB check - #29
Merged
Merged
Conversation
Fail if nohz_full= is missing from GRUB_CMDLINE_LINUX_DEFAULT and warn if the running kernel does not match yet (reboot pending). The check is off by default and only runs when checksToRun.nohzFull is explicitly true, so existing local configs without the key are unaffected. should_run_check now takes an optional default for missing keys; existing checks keep defaulting to true. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🤖 Codex ReviewNo findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nohzFullcheck, off by default:nohz_full=is missing fromGRUB_CMDLINE_LINUX_DEFAULT(whole-token match)/proc/cmdline) has nonohz_fullor a different CPU list (update-grub/ reboot pending)should_run_checktakes an optional default for missing keys.nohzFullusesfalse, so existinglocal_config.jsonfiles without the key are unaffected; all other checks still default totrueconfig.json, README and CLAUDE.md updatedEnabling on a host
In that host's
local_config.json(a full copy ofconfig.json, since it replaces it entirely), underchecksToRun:Testing
shellcheck -S warningclean;config.jsonvalidates withjqfalse→ skipped,true→ runs; other checks with a missing key still run/proc/cmdline: set and booted (pass), set but not booted (pass + warning), CPU list changed (pass + warning), missing (fail),xnohz_full=lookalike (fail)🤖 Generated with Claude Code