Skip to content

Fix temporary file registry loading and cleanup concurrency - #4

Closed
valib wants to merge 1 commit into
mainfrom
fix/temp-file-manager-loading-and-cleanup
Closed

valib wants to merge 1 commit into
mainfrom
fix/temp-file-manager-loading-and-cleanup

Conversation

@valib

@valib valib commented Oct 28, 2026

Copy link
Copy Markdown
Owner

Loading UMS.tmpmgr rewrote the file after each parsed entry, potentially losing unread entries. Cleanup also iterated an unsynchronized map while requests could modify it, and an unchecked exception could terminate the timer thread.

Load entries directly without writing, synchronize registry mutation and persistence, and contain runtime exceptions in the scheduled cleanup task. Add five regression tests covering large registries, comma-containing paths and invalid timeouts, concurrent add/scan operations, recovery after runtime failures, and expiration.

Validation: all five tests pass against the actual modified class in an isolated Java 17/JUnit harness with a minimal PMS configuration stub. The baseline logic fails regression checks. Full Maven validation was attempted but stopped before compilation because Maven Central DNS resolution failed while resolving maven-enforcer-plugin 3.6.3. This draft PR enables the repository's normal CI checks; their results are pending.

Load persisted entries without rewriting the registry while it is read.
Serialize registry mutations and writes, and keep cleanup tasks alive after runtime failures.
Add five regression tests for loading, parsing, concurrency, recovery, and expiration.
@valib valib closed this Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant