Repository navigation
Conversation
Load persisted entries without rewriting the registry while it is read. Serialize registry mutations and writes, and keep cleanup tasks alive after runtime failures. Add five regression tests for loading, parsing, concurrency, recovery, and expiration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading UMS.tmpmgr rewrote the file after each parsed entry, potentially losing unread entries. Cleanup also iterated an unsynchronized map while requests could modify it, and an unchecked exception could terminate the timer thread.
Load entries directly without writing, synchronize registry mutation and persistence, and contain runtime exceptions in the scheduled cleanup task. Add five regression tests covering large registries, comma-containing paths and invalid timeouts, concurrent add/scan operations, recovery after runtime failures, and expiration.
Validation: all five tests pass against the actual modified class in an isolated Java 17/JUnit harness with a minimal PMS configuration stub. The baseline logic fails regression checks. Full Maven validation was attempted but stopped before compilation because Maven Central DNS resolution failed while resolving maven-enforcer-plugin 3.6.3. This draft PR enables the repository's normal CI checks; their results are pending.