Skip to content

chore: fix spawn deprecation warning on dspublisher start #6296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
web-padawan merged 1 commit into from
Oct 9, 2026
Merged

chore: fix spawn deprecation warning on dspublisher start #6296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions dspublisher/dspublisher-scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ async function checkPreConditions() {

// Verify Maven is installed
await new Promise((resolve, reject) => {
const ps = spawn('mvn', ['--version'], {
const ps = spawn('mvn --version', {
stdio: 'ignore',
shell: true,
});
Expand Down Expand Up @@ -369,12 +369,14 @@ function finish() {
*/
async function execute(shellCommand, phases, ignoredLogSignals = []) {
return new Promise((resolve) => {
const parts = Array.isArray(shellCommand) ? shellCommand : shellCommand.split(' ');
const ps = spawn(parts[0], [...parts.slice(1)], { shell: true });
// Pass the whole command line as one string: with `shell: true`, Node
// would only concatenate separate args anyway, and warns about it (DEP0190).
const command = Array.isArray(shellCommand) ? shellCommand.join(' ') : shellCommand;
const ps = spawn(command, { shell: true });

ps.on('close', (code) => {
if (code !== 0) {
console.error(`${shellCommand} failed with code ${code}`);
console.error(`${command} failed with code ${code}`);
process.exit(code);
}

Expand Down
Loading