[On Hold] TEST: Remove deselected forest tests on CPU#2290
Draft
david-cortes-intel wants to merge 1 commit intouxlfoundation:mainfrom
Draft
[On Hold] TEST: Remove deselected forest tests on CPU#2290david-cortes-intel wants to merge 1 commit intouxlfoundation:mainfrom
david-cortes-intel wants to merge 1 commit intouxlfoundation:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
Is there a ticket for this? Can it be closed until work resumes (if we plan to)? |
Contributor
Author
Yes, there is a ticket for changing the default RNG, which is planned to be worked on soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a comprehensive description of proposed changes
List associated issue number(s) if exist(s): #6 (for example)
Documentation PR (if needed): #1340 (for example)
Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)
ref uxlfoundation/oneDAL#3040
After the PR switching the default random engine is merged, there should hopefully not be any need to have this test deselected anymore, since the new random engine won't suffer from the same bad initial states as the current one.
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance
Not applicable.