Add oneDPL Public CI state and requirements. by timmiesmith · Pull Request #222 · uxlfoundation/open-source-working-group

timmiesmith · 2025-04-18T20:35:45Z

Initial capture of the current state of oneDPL Public CI and what would be needed to fully test community contributions.

Fixes #208

danhoeflinger

This LGTM. I think it should be everything

* Add oneMKL info to project-ci-documentation.md * Correct some typos * Update project-ci-documentation.md * Update project-ci-documentation.md

dmitriy-sobolev · 2025-04-22T10:51:19Z

+| ninja | g++ | |
+| Visual Studio 2019 | | |
+| Visual Studio 2022 | | |



I think we should also mention the supported GPU driver and their versions. It is a yet another tool oneDPL depends on.

I think this is too much detail at this point.

The question of how much detail is needed in this document was discussed in the UXL Open Source Working Group meeting. The feedback received is that any details on configurations teams can provide is useful, so I will add the details suggested.

dmitriy-sobolev · 2025-04-22T10:58:02Z

-* CMake
-* glibc
-* ...
+| Windows | Linux | MacOS (Arm CPU testing) |


I think it would be more readable to have "Software" or "Tool" as a first column. The cells may contain for example: minimal version number, "any" or "-" (not needed).

version information is too much detail in my opinion.

Different product on one line still bothers me (such as dpc++ compiler and clang++ compiler). I suggest making a bullet list.

You can ignore this comment though - it is a matter of taste.

I've added the Software column.

dmitriy-sobolev · 2025-04-22T11:10:25Z

+| Dmitriy Sobolev @dmitriy-sobolev |
+| Timmie Smith @timmiesmith |
+
 *Existing public CI*


I think it would be nice to mention how to run this CI, e.g. that it is automatically triggered in oneDPL repository when a PR is opened and a new commit is made.

This is too much detail for what is being requested at this time.

timmiesmith · 2025-04-22T13:47:45Z

Thank you for the comments, @dmitriy-sobolev . There are several suggestions that I think would be too detailed for this document. Version numbers for drivers and software tools are something that should be captured in oneDPL system requirements documentation.

dmitriy-sobolev · 2025-04-22T14:52:44Z

+Testing on CPU platforms must exercise several execution policies with OpenMP and oneTBB to cover all of the oneDPL backends.
+| Processor Type | Execution Policy |
+| --- | --- |
+| CPU | seq, unseq, par (using oneTBB), par (using OpenMP), par\_unseq(using oneTBB), par\_unseq(using OpenMP) |
+| GPU | device\_policy |


To simplify things, I would replace the 2x2 table with a bullet list:

Suggested change

Testing on CPU platforms must exercise several execution policies with OpenMP and oneTBB to cover all of the oneDPL backends.

| Processor Type | Execution Policy |

| --- | --- |

| CPU | seq, unseq, par (using oneTBB), par (using OpenMP), par\_unseq(using oneTBB), par\_unseq(using OpenMP) |

| GPU | device\_policy |

oneDPL testing must cover all execution policies. Different device types support different sets of policies:

* CPU: seq, unseq, par, par_unseq, device_policy

* GPU: device_policy

The par and par_unseq policies must be tested with both oneTBB and OpenMP backends.

It breaks the flow with its GPU to CPU transition. Adapt the above if you find it useful.

dmitriy-sobolev · 2025-04-22T15:03:24Z

-* CMake
-* glibc
-* ...
+| Windows | Linux | MacOS (Arm CPU testing) |


Different product on one line still bothers me (such as dpc++ compiler and clang++ compiler). I suggest making a bullet list.

You can ignore this comment though - it is a matter of taste.

dmitriy-sobolev · 2025-04-22T15:14:19Z

+| Visual Studio 2019 | g++ | |
+| Visual Studio 2022 | | |


I think we can leave only one Visual Studio major version (2022) - it should be enough for a minimal CI requirements. I would say that one version is enough in 99% cases.

Also, let's be careful for the name of the product. DPC++ system requirements, for example, list it as Microsoft Visual Studio*.

…#223) * introduce initial version of CI descrition * Apply suggestions from code review Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com> Co-authored-by: Andreas Huber <9201869+ahuber21@users.noreply.github.com> * fixing links and typos * fixing links and typos * adding sklearnex ci * adding sklearnex ci * fixing typo * Apply suggestions from code review Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com> * Update project-infrastructure/project-ci-documentation.md * Update project-infrastructure/project-ci-documentation.md --------- Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com> Co-authored-by: Andreas Huber <9201869+ahuber21@users.noreply.github.com>

Co-authored-by: Dmitriy Sobolev <Dmitriy.Sobolev@intel.com>

timmiesmith · 2025-05-22T20:35:59Z

Rebase has mangled the changeset. Closing this PR and will open a clean PR with just the oneDPL CI changes.

Draft of oneDPL Public CI state and requirements.

b414a36

timmiesmith requested review from adamfidel, danhoeflinger and dmitriy-sobolev April 18, 2025 20:35

Update oneDPL required software

9eca457

timmiesmith changed the title ~~Draft of oneDPL Public CI state and requirements.~~ Add oneDPL Public CI state and requirements. Apr 21, 2025

danhoeflinger approved these changes Apr 21, 2025

View reviewed changes

Add oneMKL info to project-ci-documentation.md (uxlfoundation#220)

61f170d

* Add oneMKL info to project-ci-documentation.md * Correct some typos * Update project-ci-documentation.md * Update project-ci-documentation.md

dmitriy-sobolev reviewed Apr 22, 2025

View reviewed changes

Addressing review comments

32599dc

timmiesmith added 2 commits April 22, 2025 08:53

Add information on supported NVIDIA and AMD platforms

4b86fd4

Correct table

268239f

dmitriy-sobolev reviewed Apr 22, 2025

View reviewed changes

napetrov and others added 11 commits April 29, 2025 09:47

added April's minutes (uxlfoundation#224)

08fa6e1

Update project-infrastructure/project-ci-documentation.md

82082ab

Co-authored-by: Dmitriy Sobolev <Dmitriy.Sobolev@intel.com>

Update project-infrastructure/project-ci-documentation.md

fe4d5f5

Co-authored-by: Dmitriy Sobolev <Dmitriy.Sobolev@intel.com>

Draft of oneDPL Public CI state and requirements.

aac8e5f

Update oneDPL required software

91f66db

Addressing review comments

0d93131

Add information on supported NVIDIA and AMD platforms

286e70a

Correct table

dba3170

Resolving conflicts

cd8d670

Applying review suggesstions.

6098a30

timmiesmith closed this May 22, 2025

timmiesmith deleted the add_onedpl_ci_info branch May 22, 2025 20:36

timmiesmith mentioned this pull request May 22, 2025

Add oneDPL public CI state and requirements. #225

Merged

Conversation

timmiesmith commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danhoeflinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmitriy-sobolev Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timmiesmith commented Apr 22, 2025

Uh oh!

Uh oh!

Uh oh!

dmitriy-sobolev Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timmiesmith commented May 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

timmiesmith commented Apr 18, 2025 •

edited

Loading

dmitriy-sobolev Apr 22, 2025 •

edited

Loading

dmitriy-sobolev Apr 22, 2025 •

edited

Loading