Repository navigation
Feature/join waitlist - #21
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🚦 Quality Gate Report📊 Check Results
✅ All Checks Passed!Your code meets all quality standards and is ready to merge! 🎉 📝 Run Details
|
|
🚀 Preview deployment ready — |
patel-aaryan
requested changes
Oct 28, 2026
This was referenced Oct 28, 2026
patel-aaryan
approved these changes
Oct 30, 2026
patel-aaryan
left a comment
Member
There was a problem hiding this comment.
aside from the comment cleanup and small nits: this looks great
Co-authored-by: Aaryan Patel <86172867+patel-aaryan@users.noreply.github.com>
Co-authored-by: Aaryan Patel <86172867+patel-aaryan@users.noreply.github.com>
Co-authored-by: Aaryan Patel <86172867+patel-aaryan@users.noreply.github.com>
Co-authored-by: Aaryan Patel <86172867+patel-aaryan@users.noreply.github.com>
Co-authored-by: Aaryan Patel <86172867+patel-aaryan@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue
closes #20
Changes Made
POST /api/waitlistendpoint that accepts an email and returns the same success response for new and duplicate addresses, so it can't be used to enumerate subscribersWaitlistServiceto trim, lowercase and validate emails (length and format) before they reach the databaseWaitlistRepositorythat calls ajoin_waitlistPostgres functionwaitlisttable with RLS enabled and revokes direct table access fromapp_public. ASECURITY DEFINERfunctionjoin_waitlisthandles inserts withON CONFLICT DO NOTHING, and onlyapp_publiccan execute itjoinWaitlistclient helper and wired it intoWaitlistModal/api/waitlistthrough the coming-soon proxy so it works for signed-out visitorsAdditional Notes/Screenshots/Videos (Optional)
npm run migrate(up). Rolling back withdowndrops thewaitlisttable and its datajoin_waitlist