Input select: display selected icons fix. - #1113
Merged
Merged
Conversation
Deploying smoothly with
|
| Latest commit: |
a45eace
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f46a804f.smoothly.pages.dev |
| Branch Preview URL: | https://input-select-display-icons-f.smoothly.pages.dev |
tovebr
force-pushed
the
input-select-display-icons-fix
branch
from
August 4, 2026 07:28
0c1f25b to
a45eace
Compare
tovebr
requested review from
AntonCroner and
EliasEriksson
and
a lite review from Copilot
and removed request for
EliasEriksson
August 4, 2026 07:56
There was a problem hiding this comment.
Pull request overview
Fixes how selected values (including icons) are rendered/truncated in smoothly-input-select after a prior ellipsis/overflow change.
Changes:
- Adjusts the selected-value wrapper markup (
.value) and updates CSS to applymin-width: 0+ ellipsis behavior correctly. - Updates
displaySelected()to clone selected items and forcesmoothly-iconelements to render inline (inline-flex) so they appear correctly in the selected-value display. - Changes multi-selected value joining to use a spacing separator instead of a comma.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/input/select/style.css | Targets ellipsis/overflow styling specifically to the selected value container (.value) and ensures it can shrink within a flex row. |
| src/components/input/select/index.tsx | Ensures selected icons display correctly by adjusting cloned icon styles and renders selected values within a dedicated .value element. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AntonCroner
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I previously fixed overflow not being cutoff and displayed with ellipsis in input-select, that fix broke displaying of icons:
This fixes that:
