fix: bump stale 0.11.0 path dependency pins to 0.12.0#97
Closed
paoloantinori wants to merge 1 commit into
Closed
Conversation
crw-diff and crw-monitor were added during the 0.11 cycle but their dependency version pins (plus dependents in crw-renderer, crw-crawl, crw-server) were missed during the 0.12.0 version bump, causing: error: failed to select a version for the requirement candidate versions found which didn't match: 0.12.0 Fixes us#95 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
|
Superseded by #101 (merged) — closing. #101 fixes #95 structurally: internal crate versions are now centralized in root Two reasons not to merge this PR as-is:
Thanks for the precise root-cause writeup in #95 — it's exactly what the structural fix is built on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace was bumped to 0.12.0 in #86 but several crates still pin their path dependencies at
0.11.0, causing build failures:Affected files (10 pins across 5 files):
crates/crw-diff/Cargo.toml— crw-corecrates/crw-monitor/Cargo.toml— crw-core, crw-diff, crw-crawl, crw-extract, crw-renderercrates/crw-renderer/Cargo.toml— crw-extractcrates/crw-crawl/Cargo.toml— crw-diffcrates/crw-server/Cargo.toml— crw-diff, crw-monitorRoot cause:
crw-diffandcrw-monitorwere added during the 0.11 cycle. Their version pins (plus dependents) were missed during the 0.12.0 bump.Fixes #95
🤖 Generated with Claude Code