fix: upgrade containerd and related logic to allow parsing new containerd flags#765
fix: upgrade containerd and related logic to allow parsing new containerd flags#765Cicada1107 wants to merge 1 commit into
Conversation
✅ Deploy Preview for urunc canceled.
|
|
Hello @Cicada1107 , please read the contribution guide. |
|
Hi @cmainas, I apologize for any inaccuracies, but I'm fairly new to urunc and after reviewing the contribution guide, I'm still not entirely sure which requirement my PR is currently missing - I wasn't sure if the concern is commit organization, Code Logic, CI Requirements or something else Could you just very briefly point me to the issue or confirm if it is indeed the commit organization (should I split the changes further into multiple commits based on change logic?) so that I can address it correctly? I'm trying to be responsible and would appreciate any guidance. |
|
Hello @Cicada1107 , please do not overwrite the PR template. |
b50441f to
0a9cd86
Compare
0a9cd86 to
c1c9bbe
Compare
Signed-off-by: Arijit Dubey <arijitdubey2018@gmail.com>
c1c9bbe to
a5128eb
Compare
|
Hey @cmainas I have revamped the PR to align with the PR Guidelines. This PR follows the first approach I mentioned on slack - migrating containerd to v2. PTAL when you get the time. Thanks! And a small doubt: when I ran the LMK if you need clarification for any change or if there are any changes I should make and I will resolve them ASAP. |
Description
-info flag is a flag that was added in the containerd v2.x update and since urunc currently uses containerd v1.x to power the containerd-urunc-shim-v2 bianry, it cannot parse this flag as the old version does not have the logic to parse this new flag.
In a recent update containerd made changes to the paths to various dependencies and other structural changes.
This PR migrates urunc to the latest containerd version - containerd v2.x and makes the required changes to fix the breakages this migration causes in urunc, by accounting for the v2.x changes.
Related Issues
fixes #750
How was this tested?
makereported no errors (build successful)make lint(lint successful for changes introduced in this PR)sudo nerdctl run -d --runtime io.containerd.urunc.v2 harbor.nbfc.io/nubificus/urunc/nginx-qemu-unikraft-initrd:latestjournalctl -eu containerd.service -n 100 | catlevel=error msg=failed to load runtime info... flag provided but not defined..error.go run ./cmd/containerd-shim-urunc-v2 -infoand found no errorsLLM Usage
Gemini 3.1 Pro
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl). (make test_docker passes completely)