Repository navigation
Add sizeToContent prop and onSizeChange event to the embedded view spec - #775
Merged
Merged
Conversation
Declares the codegen surface the self-sizing work needs: a sizeToContent prop and an onSizeChange bubbling event carrying the measured height. Android registers the prop and the event constant; neither platform measures anything yet, so the flag is inert until the iOS (MOBILE-5952) and Android (MOBILE-5953) measurement lands. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Oct 13, 2026
crow
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add a
sizeToContentprop and anonSizeChangeevent to the embedded view'scodegen spec, and register both on Android.
Why are these changes necessary?
An embedded view fills whatever box the app gives it. There is currently no way
for an app to let the view size itself to its content, because there is nothing
in the spec for native to report a height through. This adds that surface so the
iOS and Android measurement can be built against it.
How did you verify these changes?
Built the example app on both platforms and confirmed codegen produces the new
prop and event. Setting
sizeToContentchanges nothing yet, which is expected.🤖 Generated with Claude Code