Add AirshipEmbeddedCarousel component by khmMouna · Pull Request #774 · urbanairship/react-native-airship

khmMouna · 2026-10-08T14:53:29Z

What do these changes do?

Adds an AirshipEmbeddedCarousel component backed by the native carousel on both platforms (AirshipEmbeddedCarousel in AirshipScenes on iOS, and in urbanairship-automation-compose on Android). It shows every pending instance for an embedded ID as swipeable pages with the default chrome (indicator, arrows).

Props: embeddedId, selection, style, currentPage (settable), and the callbacks onPageChanged, onPageCountChanged, onAvailabilityChanged, onStateChanged. Sizing follows the same rules as AirshipEmbeddedView.

JS: new component and codegen spec, registered in package.json.
iOS: Swift wrapper hosting the SwiftUI carousel with hoisted state, a Fabric/Paper view, and bridge protocols.
Android: ComposeView-based view and manager. Adds the Compose compiler plugin and the Compose BOM (runtime, ui, foundation) to android/build.gradle. The carousel artifact (urbanairship-automation-compose) now comes from airship-framework-proxy, bumped to 16.0.2 in gradle.properties.
Example app: a Carousel card on the Embedded Views screen.

Why are these changes necessary?

React Native only exposed AirshipEmbeddedView, which shows one instance at a time, so apps could not display a multi-instance embedded placement the way a native app can. Custom chrome is supplied as native view builders and does not bridge, so the default chrome is used.

Anything else a reviewer should know?

Depends on proxy 16.0.2, which is not released yet. The proxy change (airship-mobile-framework-proxy) adds urbanairship-automation-compose as an api dependency and updates the Android SDK to 21.0.3, so Android resolves the carousel artifact transitively. Until 16.0.2 is on Maven Central, Android builds of this branch will not resolve

Screen_recording_20261008_175034.webm

Screen.Recording.iPhone.17.Pro.08-10-2026.at.17.51.16.mp4

Adds a carousel backed by the native AirshipEmbeddedCarousel on iOS (AirshipScenes) and Android (urbanairship-automation-compose). Every pending instance for an embedded ID is shown as a swipeable page with the default chrome. The current page can be set from JS via currentPage, and page, page count and availability are reported through events. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

This reverts commit 28567ac.

Ulrico972 · 2026-10-16T14:27:11Z

Code Review

Took a look through the Android/iOS/JS changes — the carousel state handling (page clamping, availability reporting, event parity between platforms) looks solid and follows the existing AirshipEmbeddedView patterns closely.

One thing worth a second look before merging:

android/build.gradle unconditionally applies the Compose Kotlin compiler plugin (org.jetbrains.kotlin.plugin.compose, needs Kotlin ≥ 2.0.0) to the library module — for every consumer of react-native-airship, not just apps using the new carousel. Apps that still pin an older Kotlin version (1.9.x is still common on RN 0.72–0.74) could fail to resolve this plugin and have their Android build break entirely, not just lose the carousel.

Is raising the minimum Kotlin version here intentional and documented somewhere (CHANGELOG/README), or should the Compose dependency be scoped so it only applies when the carousel is actually used?

Also a minor nit: the compose-bom version (2025.10.01) is hardcoded rather than pulled from a property like the other versions in this file.

🤖 Generated with Claude Code

jyaganeh · 2026-10-17T00:35:10Z

Sorry I'm late to this, but I think that adding Compose may cause issues because it'll require us to apply the Compose compiler to the Gradle build for all frameworks, and I'm not sure that they'll all work well with it.

I don't think it's a bad idea to try (maybe it will work ok and I'm just being overly cautious?), but we may need to go back to the Android repo to add a carousel built with XML Views if Compose can't be brought into all the frameworks cleanly (Cordova and Unity are the ones that I'm particularly unsure about).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

…/height Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

oristanovic · 2026-10-19T12:09:33Z

+
+    // Falls back to the screen size until the first layout pass, matching the
+    // embedded view's sizing rules.
+    private var parentSize: CGSize {


parentWidth/parentHeight are optional so the SDK can resolve percent placements against the SwiftUI proposal; parentSize makes them never nil, and because the guard requires both axes, a zero height replaces the width too. The wrapper is built from initWithFrame:CGRectZero, so the first layout pass sizes percent-based content against the whole screen. main has since replaced this fallback in ReactAirshipEmbeddedView.ViewModel with per-axis nil — a rebase would bring the comment above back in line too.

oristanovic · 2026-10-19T12:09:33Z

+- (instancetype) init {
+    self = [self initWithFrame:CGRectZero];
+    if (self) {
+        self.wrapper = [[RNAirshipEmbeddedCarouselBridgeClass() alloc] initWithFrame:self.bounds];


RNAirshipEmbeddedView sets clipsToBounds = YES right here for the same hosted scene content. Without it a carousel taller than the box Yoga assigned paints over whatever sits below — in the example screen, the Instance Selection card under the 300pt container.

oristanovic · 2026-10-19T12:09:33Z

+
+        self.viewModel.size = frame.size
+
+        self.cancellable = Publishers.CombineLatest(


No removeDuplicates, and the SDK reassigns currentPage on every pending-set change, often to the value it already held, so identical state crosses the bridge repeatedly. onStateChanged is the one callback the JS side doesn't filter against lastState, so it fires each time with a fresh object. The Android path dedupes the same stream.

oristanovic · 2026-10-19T12:09:33Z

+
+    @objc(setPage:)
+    public func setPage(_ page: Int) {
+        guard page != lastRequestedPage else { return }


lastRequestedPage is never cleared, so once a page index has been requested it can't be requested again for the life of the view — and Fabric pools these, so a recycled wrapper carries the previous placement's value. Is the guard there for anything beyond redundant updateProps calls?

khmMouna requested a review from a team as a code owner October 8, 2026 14:53

khmMouna marked this pull request as draft October 8, 2026 15:05

khmMouna added 3 commits October 8, 2026 17:11

Use latest airship proxy version

28567ac

Revert "Use latest airship proxy version"

058d812

This reverts commit 28567ac.

Use airship proxy 16.0.2

b31627d

khmMouna self-assigned this Oct 8, 2026

khmMouna marked this pull request as ready for review October 16, 2026 13:30

Feedback

6ed99e4

khmMouna and others added 2 commits October 19, 2026 09:30

Mark ReactAirshipEmbeddedCarousel as MainActor to fix iOS build

04b37f8

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Compute carousel parent size locally instead of using ViewModel width…

624500d

…/height Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

oristanovic reviewed Oct 19, 2026

View reviewed changes

khmMouna added 2 commits October 19, 2026 16:33

Feedbacks

36ae182

Fix build

d97f142

Navigation Menu

Repository navigation

Add AirshipEmbeddedCarousel component - #774

Add AirshipEmbeddedCarousel component#774
khmMouna wants to merge 9 commits into
mainfrom
MOBILE-5981-embedded-carousel-is-not-available-in-react-native

khmMouna commented Oct 8, 2026 •

edited

Loading

Uh oh!

Ulrico972 commented Oct 16, 2026 •

edited

Loading

Uh oh!

jyaganeh commented Oct 17, 2026

Uh oh!

oristanovic Oct 19, 2026

Uh oh!

oristanovic Oct 19, 2026

Uh oh!

oristanovic Oct 19, 2026

Uh oh!

oristanovic Oct 19, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		self.viewModel.size = frame.size

		self.cancellable = Publishers.CombineLatest(

Conversation

khmMouna commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What do these changes do?

Why are these changes necessary?

Anything else a reviewer should know?

Uh oh!

Ulrico972 commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review

Uh oh!

jyaganeh commented Oct 17, 2026

Uh oh!

oristanovic Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

oristanovic Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

oristanovic Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

oristanovic Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

khmMouna commented Oct 8, 2026 •

edited

Loading

Ulrico972 commented Oct 16, 2026 •

edited

Loading