[danielhanchen]

Problem

scripts/unsloth/feature_matrix.py cannot run on a Windows build. bins() looks for test-backend-ops / test-llama-archs without the .exe suffix, so it exits 1 with "no test binaries under ..." before any feature is checked. The same bare names are used to launch test-llama-archs, test-backend-ops, test-mtmd-impl and llama-server.

CI is not affected (the preflight and pr-set lint jobs run on ubuntu-24.04), but running the matrix by hand on a Windows build, for example to check the pins on a Windows GPU box, fails immediately.

Change

A small exe(b, name) helper returns b / name, or b / name.exe when only the Windows binary exists. bins() and every binary path go through it. A POSIX name still wins when both exist, so Linux and macOS behaviour is unchanged.

Tests

• python3 scripts/unsloth/test_feature_matrix.py: all checks pass, including the new section 12 (a build with only .exe binaries is found, binaries resolve to .exe, a POSIX name wins when both exist). On master section 12 fails (bins() exits, no exe helper).
• With this change, feature_matrix.py --gpu on a Windows 11 HIP gfx1151 build of the b12012 pin set reports 16 / 16 features, the same as the Linux ROCm build.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-01T09:26:06.180877Z	7bba244	PR opened
🔒 Security Review	✅ Completed 2026-11-01T09:27:20.628565Z	7bba244	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.