Repository navigation
pr-set : repin #336 - #338
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repins #336 to 88a70c8. With #337 merged, the set no longer builds: #336 and the Inkling pin (ggml-org#25731) both give a new tokenizer pre-type the value 66, so
llm_tokenizer_bpe's switch insrc/llama-vocab.cpphas a duplicate case (error: duplicate case value) in the CPU gate and the CUDA build, on b11979 and b11982. Each pin merges cleanly on its own, which is why the merge dry-run stayed green.#336 now uses 100 for its pre-type. The value is internal only (GGUF files store the pre-tokenizer name, not the number), so existing files are unaffected, and 100 stays clear of the next values upstream will hand out. The new commit differs from the old one in that single line.
Verification of master with this repin (CPU gate, full CUDA build, test-chat, test-backend-ops, GPU features) on b11979 and b11982 is running; results will be added here.