Repository navigation
pr-set: repin Inkling, #298 and #320 onto b11871 - #323
Merged
Merged
Conversation
Upstream b11850-b11870 took pre-type 65 (Soprano, ggml-org#28607), forwarded the MiniMax-M3 quant scales (ggml-org#31097) and added DeepSeek-V4.1 under the deepseek41 arch name (ggml-org#31086). Each pin branch merges b11871 with the conflicts resolved.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repins three pins onto merges of b11871 so that the scheduled prebuilt builds again on the newest aged tags. Nightlies have failed since 10-22, and the #320 release currently needs a fixed
-f tag=b11849dispatch.LLAMA_VOCAB_PRE_TYPE65; ggml-org#30656 reworks the Vulkan FA accumulator precisionGGML_PREC_F32_PEDANTICto the f32-accumulator cases ofggml_vk_prec_allows_f16accfb9ddb92d->b49c8baf4DSparkMiniMaxDraftModelregistry line additiveef8f94ccb->822be707bdeepseek41arch namedeepseek41model, converter and DSV4 KV cache kept;build_hc_mixestakes upstream's new(..., bool f32_src, int il)signature, our two call sites ported;deepseek4.cppanddflash.cpptake upstreambe8365722->14539304e#298 cannot simply be dropped in favour of upstream's
deepseek41: plain b11871 aborts while loading the published DeepSeek-V4.1-Flash UD-IQ1_M (GGML_ASSERT(*cur_backend_id != -1)).Changes
scripts/unsloth/pr-set.json: the three pin URLs above move to the new commits. Each new commit is a fast-forward of the old one. Order, count (23) andfeature-checks.jsonare unchanged.Evidence
sim --tags b11871,b11873,b11874(window): ok on all three tags, 23 pins,pin_contractintact,merge_checksclean, ggml-org#25731 and #70 additive.At b11871 the first
MUL_MATpass flagged one case,q4_1 x f32, m=16, n=1, k=32. That case passed 5/5 targeted reruns, and the whole op then passed 2582/2582. It is a 16x32 q4_1 matmul that none of the three repinned branches touch.Numeric checks on the published GGUFs (wikitext-2,
-c 512):Against Inkling's own pre-merge head (
fb9ddb92dalone),b49c8baf4moves by KLD 0.208. All of that comes from ggml-org#31086'ssoftpluschange, which the current prebuilt already ships.fb9ddb92dplus only that change reproduces the new numbers exactly, so the released prebuilt does not move.Not covered: ROCm, Vulkan, Metal, macOS, Windows and ARM legs (these run on the nightly).