Skip to content

feat: integrate checkpoint B credentials and client improvements - #14

Merged
unlockdigital merged 25 commits into
unlock-digital/mainfrom
maintenance/upstream-checkpoint-b-20261105
Nov 7, 2026
Merged

unlockdigital merged 25 commits into
unlock-digital/mainfrom
maintenance/upstream-checkpoint-b-20261105

Conversation

@unlockdigital

@unlockdigital unlockdigital commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

This checkpoint carries the approved upstream credential, usability, approval, and scheduling improvements into the fork while preserving its security patches, private routing, account behavior, and migration bridge.

Changes

  • Reconcile the November 5 Codex account-lock and full model-label fixes.
  • Add R6 source-control and usage credential references with capability negotiation, legacy-client masking, schema-aware validation, destination binding, consistent credential snapshots, and cancellation-safe migration writes.
  • Add R7 account labels, model and effort history, usage filtering, bounded recovery reads, reduced thread-family loading, and sidebar and side-chat render improvements.
  • Add R9 child approvals with child-environment permission checks and environment-scoped request identity.
  • Add R10 one-time schedules and fork-aware thread links. Enabled schedules missed while offline catch up once, and re-enabling a past schedule requires a future time.
  • Pin Electron 44.10.2 and backport the embedded Cursor URI and Claude qs fixes while retaining the existing Zod backport and dependency security floors.

Validation

  • vp run check:changed origin/unlock-digital/main --concurrency 2 passes on 47d75e40544b163e56e90b2b7c2966e919650614.
  • 1,249 tests pass across 86 files, along with 48 React Compiler checks and all 39 affected-package typechecks.
  • Format, lint, Knip, generated GraphQL checks, and unused dependency-patch validation pass.
  • A frozen install, 11 focused security tests, installed SDK bundle hashes, and all 22 resolved dependency security floors pass.
  • A fresh build:desktop completed all five web/server/desktop bundle tasks on November 6. The emitted Claude SDK source map matches the approved patched bundle hash. Cursor remains a runtime external, with its three installed bundle hashes verified by the offline guard. Packaging and runtime execution remain separate qualification steps.
  • The bundle build emitted large-chunk, optional dbus-next/x11, and Effect CommonJS import.meta warnings for package-level review.
  • The November 6 offline dependency guard passed all 22 scoped resolved package floors and approved SDK hashes. With maintainer authorization to send dependency metadata to npm, the November 6 audit completed with zero critical, one high, four moderate, and one low finding. The six advisory IDs, severities, affected resolved versions, and fix ranges match the November 5 audit. Dependency-path listings differ between reports. The six findings and the separately tracked embedded-dependency questions remain open.
  • The side-chat regression fails before the optimization with 11 renders and passes with the optimized implementation.
  • Independent Terra reviews found no new actionable defect in the credential snapshot/cancellation corrections or the provider-instance snapshot fix. The latter passed 86 focused registry, hydration, and refresh tests, after eight of nine new regressions failed before the fix. Validation used CLI tools and isolated headless fixtures.
  • Actual checkpoint A and B settings services passed a synthetic B-to-A-to-B roundtrip. Credential references, usage filtering, and private routing survived an A save with zero protected stale-secret reads. Both client contract versions decoded their compatible settings payloads. A retained message text while ignoring the optional model-switch badge, and its focused schedule test retained an unsupported once row without executing it.

Checkpoint B qualification

Source integration merged into unlock-digital/main as 165192e94713c944c27a84a47f4f2de8f930b601 after required CI passed on the reviewed head. Release qualification is the next stage of the approved sequence.

  • Obtain maintainer acceptance of the measured agent-context increase through the repository's agent-context-increase label gate. The maintainer approved the 74-byte instruction increase per provider and the 81-byte MCP tool-definition increase on November 6.
  • Correct and assess cross-account snapshot consistency through provider-instance hydration, reconciliation, and manual refresh. Commit 47d75e4054 pins config and vault settings together and preserves nonblocking startup and legacy map-only callers. Independent review accepted the correction.
  • Resolve or qualify the six workspace audit findings, currently one high, four moderate, and one low, with package compatibility and runtime applicability evidence.
  • Resolve embedded legacy Zod v3 and Claude URI parser exposure questions.
  • Verify synthetic checkpoint-A/B settings roundtrips and client codecs, optional model-history decoding, and unsupported schedule-row handling with the exact published A checkout.
  • Complete historical-database replay and end-to-end rollback qualification beyond the synthetic settings/codec fixtures.
  • Verify mixed client/server versions and local, remote, relay, and tunnel connection modes.
  • Complete integrated client verification and before/after UI evidence.
  • Verify packaged artifacts, embedded patches, signing metadata, migration fixtures, backups, and rollback before release and activation.

Implemented and reviewed with GPT-6.1 Sol and Terra through the Codex harness in T3 Code, with Luna supporting advisory research.

Reconcile the accepted local runtime at 8819b23f461bcbb3a8089dd3bb26b37ab30d6e92. Preserve full model labels and link the Codex shared session-index lock before account startup. The existing lock regression failed on the canonical baseline and all nine focused cases pass with the fix. Integrated visual acceptance is reserved for checkpoint-B qualification.
…ence

Integrate upstream 84537c4, bff68fb and a104909 as one atomic group. Preserve the fork credential collision guards and private routing while enabling references, mask references for older clients, and advertise the new field support separately from existing provider references. Include console-billing reference recognition. Focused backend and compatibility suites passed 173 cases, seven affected package typechecks passed, and before-fix failures reproduced per-host resolution, usage-key decoding and opaque-reference handling. Full checkpoint-B qualification follows the approved implementation tranche.
Adapted from upstream 0343c83.

(cherry picked from commit 90b5b599468af38112e2ed450266bc649ff27025)
Adapted from upstream 2c59bf6.

(cherry picked from commit 6287ca8cba7cfea90371ef4322a8d3a23bf3def5)
Adapted from upstream c65f8d5; preserve queued selection when promoting a message.

(cherry picked from commit 737f9e59155f36e302cc3c9643753afdefbc9ddb)
Adapted from upstream e6e2ab0.

(cherry picked from commit b5d09a2af6fe30a2a6d76088c31b35fe6493aca3)
Adapted from upstream d833184 using the existing owner index.

(cherry picked from commit 7d7cd21843c4bd1fd523883bb98d954522a777aa)
Adapted from upstream eef35b0.

(cherry picked from commit bff8309b0761f59c687c7f0cff32304e9ef17105)
Adapted from upstream 39bca53.

(cherry picked from commit 4331891952611e9e77aa51352c0620425483f90a)
Adapted from upstream 2f777bd.

(cherry picked from commit 1e3b735e2599f94b58def47330812f0a5f5d0cb6)
Adapt upstream 70f475f for web and mobile. Route actions to the child environment and preserve existing provider policy.

(cherry picked from commit 066b62823d8eccd1b6228061c23733e222bb189c)
Adapt upstream 4ac97be. Persist UTC instants and catch up enabled one-time tasks on restart. Keep the fork schedule filter and MCP policy compatible with the new trigger.

(cherry picked from commit 87f01f913ed1522474e3526f160ebdc8c3d9dc72)
Adapt upstream 251369d to use the installed product scheme and environment-scoped references. Keep reached-origin links for external MCP callers and preserve thread chip paste across web and mobile.

(cherry picked from commit e442442e1b19d19e2f0688a2f952f8b70dae7308)
(cherry picked from commit 41cdab069a01bbd7c95ac157bdf5216a6b913d87)
(cherry picked from commit 8c7f1dfc7f8e3a6d8a6ad1afb6a52096f964aed7)
Validate raw schemes in Cursor SDK 1.0.38's CJS, ESM, and Bun
fast-uri factories. The two substitutions per bundle follow the
GHSA-w74x-v6f9-j3xg / CVE-2026-110306 fix in fast-uri 3.1.9.
fastify/fast-uri@39933a1
fastify/fast-uri@597f254
fastify/fast-uri@e60e716

Backport qs 6.16.1's defensive comma coercion into Claude SDK 0.3.276,
including the upstream nullish mapping behavior on the values-only
path. Retain the existing Zod array bounds hunk.
GHSA-6pq8-jhm2-2vcw
ljharb/qs@a952e75

Guard the installed bundles by version and SHA-256. The extracted
factories reproduced scheme decoding and comma coercion errors before
the fixes. The frozen install passes all 11 focused tests afterward.

GPT-6.1 Sol via Codex in T3 Code

(cherry picked from commit 9a36073f76a984b1cc73e2fd0b6741ba5daad723)
Address both P1 findings from the independent R6 review. Use declared schemas for scalar and keyed credentials, decode host entries before merging or persisting them, and honor redaction echoes only for current saved slots. Preserve canonical host collision rejection and private routing. Regressions demonstrated plaintext bypass, lost padded references, malformed data acceptance and stale credential revival before the fix. The focused settings, source-control and privacy suite now passes 75 cases.
Use the actual custom origin or a versioned Unlock Digital preview scheme when available. Fall back to environment-scoped v2 Markdown references for unbranded clients, preserving clipboard-to-chip behavior and avoiding an implicit official-app target. The new fallback regression failed before the correction and all 71 focused link and clipboard cases pass.
Pin Electron 44.10.2 with its published integrity and unchanged dependency/engine constraints, preserving all fork overrides and vendor backports. This compatible release includes bundled Node 24.22.2 and upstream Chromium/V8-related backports. Add an Electron 44 floor to the resolved-lockfile guard. The downgrade regression failed before the policy update; all 11 installed-vendor and dependency-security tests pass after the frozen install.
Close the follow-up R6 review findings with input-free credential errors, collision rejection for declared keyed maps, destination-bound usage echoes, and retry-safe legacy secret migration.
The original streaming-only scenario also passed without the optimization. Drive actual parent composer changes and require observable ChatView renders. The corrected regression fails with eleven SideChatPane renders before the optimization and passes with the optimized implementation.
Resolve concurrent migration and secret materialization under the existing settings semaphore. Preserve each buffered change with its matching credentials, and apply canonical precedence before validating retired source-control blocks.
Keep the forward-read test on an unknown future schedule type now that once is supported. Stub the native link module alongside the other native boundaries in the mobile media fixture. Both previously failing suites now pass 93 tests.
Resolve source-control and usage references against the provider configuration captured with their destination. Keep cache identity specific to its driver and config. Complete cold migration mutations before cancellation can release the settings permit.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. labels Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB −6 B (−0.1%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.3 KiB 1.2 KiB −6 B (−0.5%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 21.6 KiB 21.6 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.1 KiB 5.1 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.3 KiB 1.3 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.9 KiB 21.9 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: d9a8a1e · PR result: 47d75e4 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@unlockdigital unlockdigital added the agent-context-increase Maintainer-approved increase in measured agent context. label Nov 6, 2026
Carry the instance and vault configuration together through hydration, reconciliation and refresh. Sample current settings under the registry permit, preserve nonblocking startup and standalone callers, and prevent stale queued work from mixing credential versions.
@unlockdigital
unlockdigital marked this pull request as ready for review November 7, 2026 01:49
@unlockdigital
unlockdigital merged commit 165192e into unlock-digital/main Nov 7, 2026
34 of 35 checks passed
@unlockdigital
unlockdigital deleted the maintenance/upstream-checkpoint-b-20261105 branch November 7, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-context-increase Maintainer-approved increase in measured agent context. 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant