Skip to content

fix(fork): integrate checkpoint A security and provider updates - #13

Merged
unlockdigital merged 11 commits into
unlock-digital/mainfrom
maintenance/upstream-checkpoint-a-20261104
Nov 4, 2026
Merged

unlockdigital merged 11 commits into
unlock-digital/mainfrom
maintenance/upstream-checkpoint-a-20261104

Conversation

@unlockdigital

@unlockdigital unlockdigital commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

This brings the approved checkpoint-A upstream fixes into the Unlock Digital fork while preserving its dependency patches, account routing, privacy controls, and migration bridge. It updates bundled browsers, provider modes and Codex recovery, diagnostic redaction, and delegation/Claude Stop behavior. Forward-read safeguards preserve newer credential-reference settings and unsupported schedules during rollback.

The Claude SDK remains pinned with a reviewed backport for its embedded Zod v4 leading-bound array checks. The dependency guard validates resolved security floors and the installed SDK bundle hash. CI uses native pnpm for the advisory threshold. The fork web job has a twenty-minute budget for dependency setup, the full suite and production boot; individual test deadlines stay at their existing values.

PDF reload coverage runs as three focused scenarios. It preserves the page, zoom, scroll offsets, fit-width mode and reset on another file path within the normal test budget.

Validation: checkpoint-wide changed-file checks pass, including 1,519 tests across 28 files and typechecks for 39 affected packages. The final test-only correction check passes all 135 tests in the affected file, format, lint, knip and affected typechecks. Frozen installation and macOS arm64 packaging pass. Packaged server files match the build; the package retains the Unlock Digital preview identity and protocol. The two credential-collision findings were independently reviewed and corrected. Full PR CI passed on bc4d5ae, including all 5,295 web tests and production boot: https://github.com/unlockdigital/t3code/actions/runs/41916926254. The final thread-transfer report remains within all enforced ceilings.

Qualification: six workspace advisories remain documented separately from the dismissed reference-only alerts. Legacy SDK Zod v3 reachability remains unresolved. The production restart prompt is unchanged; only offline eval preparation is included. Native visual verification was stopped at the user's command-line-only direction. Current live application data and the original dirty checkout are preserved. Checkpoint B and managed client policies remain outside this change.

Implemented with Codex (GPT-6.1 Sol), with scoped Luna, Terra, and Sol implementation and independent reviews.

Backport upstream ad4bb6d and dcc31b8. Verify the Chrome macOS arm64 archive independently.

Apply compatible node-forge, shell-quote, smol-toml, path-to-regexp and dbus-next XML fixes. Preserve the existing fork patches and add a multi-document resolved-lockfile security check to CI and release builds. Workspace audit findings remain separate from reference-only Dependabot alerts.
Backport upstream b6bd84d, 3e0d877, a445272 and ba962f2.

Advertise Antigravity runtime modes, respect configured Codex homes, surface active-writer conflicts, and share the bounded archived-session recovery path for checkpoint restoration. Retain fork routing and privacy behavior.
Backport upstream b8ca826 and 1f87f64.

Share data-URL payload redaction across server and desktop preview reports while preserving internal navigation URLs. Redact Muse authentication banners before persisting provider-session errors.
Backport upstream 4c91892, aeaf363 and 7195b69.

Filter unsupported inherited options consistently, reflect caller-project provider disablement in the capabilities catalog, and bound Claude Stop acknowledgement. Keep existing dispatch authorization and private-helper restrictions.
Prepare the rollback checkpoint for reference credentials from upstream 84537c4, bff68fb and a104909, Usage filters from e6e2ab0, and once schedules from 4ac97be.

Keep supported settings and private routing intact, retain opaque references and Usage filters on disk, suppress stale credential materialization, and reject replacement of unsupported credentials. Omit unsupported schedules from lists while retaining their rows and existing non-execution behavior. This introduces no migrations.
Reject normalized host collisions before rewriting saved references or processing settings updates. Canonicalize credential maps before validating protected slots, and prevent protected secrets from entering materialization for each cached or emitted settings snapshot.

Regression fixtures fail before the fix for aliased updates and both saved-key orders. Preserve rejected settings byte for byte and verify stale secret-store entries are never read.
Backport the upstream leading-bound checks into the pinned Claude SDK bundle and verify the installed bundle digest. Preserve check ordering, custom errors and asynchronous parsing with bounded regression coverage.

Upstream: colinhacks/zod a0ebf970f2d752e5f58527cd2942ff48be4f46bd (GHSA-mrhx-c7xc-m3w5). Scope: embedded Zod v4 array path; legacy v3 and unconstrained collections retain separate qualification.
Use pnpm directly for the critical audit threshold because the Vite+ package-manager adapter rejects audit-level. The tested command retains all lower-severity findings in its output.
Exercise the current continuation prompt after interrupted actions and read-only checks. Grade target-specific verification before a retry and preserve fake conversation history. The production instruction text remains unchanged; real-model baseline and candidate evaluation are deferred.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 21.6 KiB 21.6 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.1 KiB +6 B (+0.1%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.3 KiB 1.3 KiB +6 B (+0.5%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.9 KiB 21.9 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: 0104640 · PR result: bc4d5ae · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

The combined PDF regression reached the normal 15-second limit at different steps on loaded CI runners. Split revision, fit-width, and path-reset coverage into focused cases while retaining the assertions and nonzero horizontal-scroll precondition.
The fork completed all 5,295 web tests and the production boot check, but dependency setup plus validation exceeded the job’s ten-minute ceiling. Allow twenty minutes on fork runners while retaining upstream’s job budget and existing individual-test deadlines.
@unlockdigital
unlockdigital merged commit d9a8a1e into unlock-digital/main Nov 4, 2026
28 of 29 checks passed
@unlockdigital
unlockdigital deleted the maintenance/upstream-checkpoint-a-20261104 branch November 4, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant