Repository navigation
Conversation
bachase
reviewed
Sep 25, 2026
bachase
left a comment
bachase
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this PR @Asterisk-Hunter . On small suggestion but otherwise looks good.
| #. Estimate how much the technique is expected to reduce gate counts or compile time. This rough estimate helps us prioritize techniques. | ||
| #. Specify which types of circuits are expected to improve or not improve with this technique. | ||
| #. Define test circuits of the above types which you will use to validate the technique. | ||
| If you have an idea for a new compiler pass, please feel free to create an `issue <https://github.com/unitaryfoundation/ucc/issues/new/choose>`_. |
Collaborator
There was a problem hiding this comment.
Consider linking directly to the new pass issue template via /discussions/new?category=new-compiler-pass
Contributor
Author
bachase
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #376
As suggested in #376, the "Proposing a New Compiler Pass" section of the contributing guide duplicated the content now living in the New Compiler Pass Proposal discussion template, risking the two drifting apart.
Changes
docs/source/contributing.rst: removed the duplicated checklist of what the proposal must contain and replaced it with the short wording proposed in Remove duplicate docs content on Proposing a new pass #376 ,an informalissuelink for early ideas, and a link to the discussion template for formal proposals.Validation
uv sync --all-extras --all-groupssphinx-build -M html docs/source— succeeds with no warningssphinx-build -M doctest docs/source -W --keep-going -n(mirrors CI) — 7 passed, 0 failurespre-commit run --files docs/source/contributing.rst— passed