Repository navigation
fix: reject non-integer CPU replay entries - #618
Merged
Merged
Conversation
Use the Python integer-index protocol before narrowing replay entries to bytes, so numeric strings, bytes, and floats cannot bypass validation. Retain Python boolean and Python/NumPy integer bit inputs and the existing record-length checks. Cover rejected values and valid deterministic bits. Closes #611 Assisted-by: Codex (GPT-6) <noreply@openai.com>
bachase
marked this pull request as ready for review
October 24, 2026 16:06
Contributor
|
Contributor
🐤 Performance CanaryNo confirmed regressions detected. 1 benchmark comparison was inconclusive. This does not block merging.
Compared Environment and method
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The private CPU replay binding accepted numeric strings such as
"0"because nanobind converted entries touint8_tbefore Clifft validated them. This reproduces with the locked nanobind 2.11.0 on CPython 3.14.2; numeric bytes andnumpy.float32(0)also passed through.Keep entries as Python objects until applying Python's integer-index protocol and checking that each value is 0 or 1. Python booleans and Python/NumPy integers remain supported, with the existing container and record-length validation preserved. Add regression cases for string, bytes, and floating-point inputs, plus valid boolean/integer branches.
Closes #611. Discovered during #610; this fix changes only the private CPU replay binding and its tests.
Test plan
cp312-abi3wheel with nanobind 2.11.0. All 47 GPU-reference tests pass on CPython 3.12.14, 3.13.11, and 3.14.2.uv run --frozen --only-group dev pre-commit run --all-files --show-diff-on-failurepasses.Contributor agreement
Assisted-by:trailer.