chore: fix tests typecheck - #637
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughChangesResolver validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized test-only change, and no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes test type-checking by explicitly narrowing Metro’s resolution union before accessing
Confidence Score: 5/5The PR appears safe to merge with no actionable issues identified. The added guard narrows the resolution union to the variant already guaranteed by the test fixture before accessing its file path.
|
| Filename | Overview |
|---|---|
| packages/uniwind/tests/native/bundler/resolvers.test.ts | Adds a valid type-narrowing guard consistent with the deterministic source-file resolution returned by the test fixture. |
Reviews (1): Last reviewed commit: "chore: fix tests typecheck" | Re-trigger Greptile
Summary by CodeRabbit