chore: remove filterFn and create string directly - #632
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe CSS processor now builds filter expressions inline. Quoted amounts remain unchanged, while unquoted amounts receive parentheses. The unused ChangesFilter formatting
Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to This is a small, localized change with no identified correctness or production-impact risk; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR removes the native runtime’s filter-formatting helper and emits equivalent filter strings directly from the CSS processor.
Confidence Score: 5/5The PR appears safe to merge with no changed-code-triggered defects identified. The generator and runtime changes are paired, no remaining repository code or declared runtime contract references the removed helper, and covered filter forms preserve their existing React Native string output.
|
| Filename | Overview |
|---|---|
| packages/uniwind/src/bundler/css-processor/functions.ts | Replaces generated rt.filterFn calls with equivalent inline string concatenation; standard filter inputs retain their expected output. |
| packages/uniwind/src/core/native/runtime.ts | Removes the unused runtime helper after the generator’s sole dependency on it was eliminated. |
Reviews (1): Last reviewed commit: "chore: remove filterFn and create string..." | Re-trigger Greptile
|
🚀 This pull request is included in v1.11.0. See Release v1.11.0 for release notes. |
Summary by CodeRabbit