Skip to content

chore: update color scheme handling for React Native 0.87 compatibility #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpudysz merged 1 commit into from
Aug 12, 2026
Merged

chore: update color scheme handling for React Native 0.87 compatibility #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions packages/uniwind/src/core/config/config.common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,15 @@ import type { CSSVariables, GenerateStyleSheetsCallback, ThemeName } from '../ty
const SYSTEM_THEME = 'system' as const
// Platform.constants is not defined in RNW
const RN_VERSION = Platform.constants?.reactNativeVersion?.minor ?? 0
const UNSPECIFIED_THEME = RN_VERSION >= 82 ? 'unspecified' : undefined
// RN 0.87 deprecated 'unspecified' in favor of 'auto'
const SYSTEM_COLOR_SCHEME = RN_VERSION >= 87
? 'auto'
: RN_VERSION >= 82
? 'unspecified'
: undefined

Comment thread
jpudysz marked this conversation as resolved.
// RN <0.87 also reports 'unspecified'
type RNColorScheme = 'light' | 'dark' | 'unspecified' | null | undefined

export class UniwindConfigBuilder {
protected _themes = ['light', 'dark']
Expand All @@ -18,9 +26,10 @@ export class UniwindConfigBuilder {

constructor() {
Appearance.addChangeListener(event => {
const colorScheme = event.colorScheme === 'unspecified'
const eventColorScheme = event.colorScheme as RNColorScheme
const colorScheme = eventColorScheme === 'unspecified'
? ColorScheme.Light
: event.colorScheme ?? ColorScheme.Light
: eventColorScheme ?? ColorScheme.Light
const prevTheme = this.#currentTheme

if (this.#hasAdaptiveThemes && prevTheme !== colorScheme) {
Expand All @@ -44,7 +53,7 @@ export class UniwindConfigBuilder {
}

private get colorScheme() {
const colorScheme = Appearance.getColorScheme()
const colorScheme = Appearance.getColorScheme() as RNColorScheme
Comment thread
jpudysz marked this conversation as resolved.

if (colorScheme === 'unspecified') {
return ColorScheme.Light
Expand All @@ -66,7 +75,7 @@ export class UniwindConfigBuilder {

if (Platform.OS !== 'web') {
// @ts-expect-error RN >0.82 - breaking change
Appearance.setColorScheme(UNSPECIFIED_THEME)
Appearance.setColorScheme(SYSTEM_COLOR_SCHEME)
}

return
Expand All @@ -84,7 +93,7 @@ export class UniwindConfigBuilder {
// @ts-expect-error RN >0.82 - breaking change
isAdaptiveTheme
? this.#currentTheme as ColorScheme
: UNSPECIFIED_THEME,
: SYSTEM_COLOR_SCHEME,
)
}
} finally {
Expand Down