Skip to content

chore: typecheck tests - #626

Merged
Brentlok merged 2 commits into
mainfrom
ci-typecheck-tests
Aug 12, 2026
Merged

chore: typecheck tests#626
Brentlok merged 2 commits into
mainfrom
ci-typecheck-tests

Conversation

@Brentlok

@Brentlok Brentlok commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Tests

    • Improved TypeScript validation for the test suite.
    • Updated test configuration and browser test handling for more reliable checks.
    • Corrected native test type references.
  • Chores

    • Added test type-checking to automated pre-commit, CI, and release validation.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 64325862-3444-4c05-8dcc-e890d751d269

📥 Commits

Reviewing files that changed from the base of the PR and between 7c1abb5 and e0a47b4.

📒 Files selected for processing (2)
  • .github/workflows/ci.yaml
  • .github/workflows/release.yaml

📝 Walkthrough

Walkthrough

The PR adds TypeScript checking for the Uniwind test project, integrates it into local and workflow validation, updates test compiler settings, and fixes two test source references.

Changes

Test TypeScript checking

Layer / File(s) Summary
Configure test type-checking
packages/uniwind/tsconfig.test.json, packages/uniwind/package.json, turbo.json, .github/workflows/ci.yaml, .github/workflows/release.yaml
The test TypeScript configuration and no-emit check script are updated. Precommit, CI, and release workflows run the test type checker.
Update test TypeScript compatibility
packages/uniwind/tests/e2e/getWebStyles.test.ts, packages/uniwind/tests/native/utils.ts
The browser evaluation callback now uses named arguments. The RNStyle import uses the corrected relative path.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding TypeScript checks for tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci-typecheck-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 12, 2026

Copy link
Copy Markdown

Greptile Summary

The PR adds automated TypeScript checking for regular Uniwind test files and corrects test-specific configuration and references.

  • Adds the check:typescript:test package script to CI, release validation, and the Turbo pre-commit pipeline.
  • Configures the test TypeScript project to include source and regular tests while excluding separately checked type tests.
  • Corrects native test type imports and Playwright evaluation argument typing.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
.github/workflows/ci.yaml CI now directly runs the regular test-suite TypeScript check from the Uniwind package.
.github/workflows/release.yaml Release validation now applies the same test-suite TypeScript check as CI.
packages/uniwind/package.json Adds a script that type-checks the dedicated test TypeScript project without emitting output.
packages/uniwind/tsconfig.test.json Configures regular test type-checking while leaving dedicated type tests to their existing configuration.
turbo.json Registers the package test-typecheck task and adds it to pre-commit dependencies.

Reviews (2): Last reviewed commit: "chore: add to ci" | Re-trigger Greptile

Comment thread turbo.json
@Brentlok
Brentlok merged commit 54260e3 into main Aug 12, 2026
3 checks passed
@Brentlok
Brentlok deleted the ci-typecheck-tests branch August 12, 2026 05:49
@github-actions

Copy link
Copy Markdown
Contributor

🚀 This pull request is included in v1.11.0. See Release v1.11.0 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant