Detailed error messages and requirements help text#72
Open
MrRob100 wants to merge 7 commits into
Open
Conversation
- Inject a Password requirements list above the new-password input on every form that sets a password (registration, change/reset password, login change, admin add/edit user). Hide the redundant FBV "must be at least N characters" sub-label and reserve a 24px gap above the confirm field. - Replace per-rule errors with a single message that names every failed requirement (length + complexity rules), rewriting Form::_errors so the combined message wins over the form-level length validator's first-error. - Extend SecurityRules, Blocklist, and LimitReuse to also hook userdetailsform so admin-created users go through the same checks. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error messages and help text reflecting password requirements instead of only showing password length requirement. These rules have been added for adding users as well as changing passwords