Skip to content

Docs/update code sec docs and workflow - #49

Merged
sumau merged 14 commits into
mainfrom
docs/update-code-sec-workflow
Jul 23, 2026
Merged

Docs/update code sec docs and workflow#49
sumau merged 14 commits into
mainfrom
docs/update-code-sec-workflow

Conversation

@sumau

@sumau sumau commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Description

  • resolves Make Code Sec workflow clearer #51
  • separates the security checklist from the security policy
  • explains what this repo does in the README
  • most of the changes are largely cosmetic apart from introducing a new requirement to complete training

Contributors

  • @rowan-trade for creating the orginal version of the diagram

Type of change

  • Refactoring (made code better without changing its behaviour)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How this has been tested

This is documentation so not testable, but I have made sure the links work correctly

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Reviewer Checklist

  • I have reviewed the PR and ensured no secret values are present

@sumau
sumau marked this pull request as draft July 1, 2026 15:43
@sumau
sumau force-pushed the docs/update-code-sec-workflow branch from 48b9bb4 to 756711e Compare July 6, 2026 10:14
Signed-off-by: DBT pre-commit check
@sumau
sumau force-pushed the docs/update-code-sec-workflow branch from 325a298 to b8d9d28 Compare July 14, 2026 16:33
@sumau sumau changed the title Docs/update code sec workflow Docs/update code sec docs and workflow Jul 14, 2026
Signed-off-by: DBT pre-commit check
@sumau
sumau marked this pull request as ready for review July 15, 2026 09:04
Soumaya.Mauthoor added 6 commits July 15, 2026 18:05
Signed-off-by: DBT pre-commit check
Signed-off-by: DBT pre-commit check
Signed-off-by: DBT pre-commit check
Signed-off-by: DBT pre-commit check
Signed-off-by: DBT pre-commit check
Signed-off-by: DBT pre-commit check

@Freshrojek Freshrojek left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, we can update as/when needed following ongoing discussions of when to bypass vulnerabilities

Comment thread templates/SECURITY_CHECKLIST.md Outdated
Comment thread SECURITY.md Outdated
Comment thread SECURITY.md
Comment thread SECURITY.md Outdated
Comment thread SECURITY.md Outdated
@github-actions

Copy link
Copy Markdown

Your PR has commits that are missing the Signed-off-by trailer. This is likely due to the pre-commit hook not being configured on your local machine. The usual fix for this issue is to run pre-commit install --install-hooks --overwrite -t commit-msg -t pre-commit, however for more detailed help in setting up the pre-commit hooks, follow the instructions at https://github.com/uktrade/github-standards/blob/main/README.md#usage

@github-actions

Copy link
Copy Markdown

Your PR has commits that are missing the Signed-off-by trailer. This is likely due to the pre-commit hook not being configured on your local machine. The usual fix for this issue is to run pre-commit install --install-hooks --overwrite -t commit-msg -t pre-commit, however for more detailed help in setting up the pre-commit hooks, follow the instructions at https://github.com/uktrade/github-standards/blob/main/README.md#usage

@github-actions

Copy link
Copy Markdown

Your PR has commits that are missing the Signed-off-by trailer. This is likely due to the pre-commit hook not being configured on your local machine. The usual fix for this issue is to run pre-commit install --install-hooks --overwrite -t commit-msg -t pre-commit, however for more detailed help in setting up the pre-commit hooks, follow the instructions at https://github.com/uktrade/github-standards/blob/main/README.md#usage

1 similar comment
@github-actions

Copy link
Copy Markdown

Your PR has commits that are missing the Signed-off-by trailer. This is likely due to the pre-commit hook not being configured on your local machine. The usual fix for this issue is to run pre-commit install --install-hooks --overwrite -t commit-msg -t pre-commit, however for more detailed help in setting up the pre-commit hooks, follow the instructions at https://github.com/uktrade/github-standards/blob/main/README.md#usage

Signed-off-by: DBT pre-commit check
@sumau
sumau merged commit 4e51da8 into main Jul 23, 2026
6 checks passed
@sumau
sumau deleted the docs/update-code-sec-workflow branch August 3, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Code Sec workflow clearer

3 participants