Repository navigation
fix(tgb): drop per-column zstd expansion cap - #332
Merged
Merged
Conversation
Summary: Intent: - Valid graphs with no tags (e.g. web-code, ~770k nodes) are rejected as "corrupt TGB graph blob", failing GetChangedTargets and GetChangedTargetsAndEdges for every commit. - TAG_DEG is one byte per node; with no tags it is all zeros and compresses to ~100 bytes regardless of node count, so its ratio (~7,600x) exceeds the 4096x cap once a graph passes ~414k nodes. Changes: - Remove the per-column maxZstdExpansion check from validateColumns. A compression ratio is not a memory bound for constant-valued per-node columns. - Keep the real bounds: maxColumnRawSize, the total-raw budget against file size, and the per-node checks against nodeCount. - Add a regression test that round-trips a 700k-node tagless graph and asserts TAG_DEG exceeds the old 4096x ratio. - Update comments in format.go and reader.go that referenced the removed cap. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
yushan8
marked this pull request as ready for review
October 9, 2026 16:56
xytan0056
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Issues