Repository navigation
Conversation
manjari25
marked this pull request as ready for review
October 22, 2026 05:48
manjari25
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 22, 2026 05:48
manjari25
added this pull request to stack #912
October 22, 2026 05:48
|
|
||
| "github.com/uber/tango/tangopb" | ||
| "go.uber.org/yarpc" | ||
| yarpcgrpc "go.uber.org/yarpc/transport/grpc" |
Collaborator
There was a problem hiding this comment.
does this work with what we import internally? as these could be different?
Contributor
Author
There was a problem hiding this comment.
Do you mean version of go.uber.org/yarpc internally? If so, it should work. Internally we use at least what is pinned in the oss repo here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The tango analyzer and its client adapter have no way to run in the reference orchestrator. This wires them in so a queue can select
analyzer: tango.What?
tangoclient:Dialopens a lazy gRPC connection to Tango.Connection.ChangedTargetsClientbuilds the adapter for a remote and strategy (unset,shell,native).tangoblock (address,signatureCacheBytes) and a per-queueanalyzer.tangoblock (remote,strategy).gitrepo.Repolock as the git change provider.nativeneedsgithub://URIs that the git provider doesn't emit.Test Plan
Issue