Skip to content

feat(stovepipe): Show most broken projects first - #903

Draft
prathshenoy wants to merge 1 commit into
mainfrom
feat/stovepipe-degree-order
Draft

feat(stovepipe): Show most broken projects first#903
prathshenoy wants to merge 1 commit into
mainfrom
feat/stovepipe-degree-order

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

What:

  • List all recorded projects from most broken to least broken, using ascending project IDs to break ties.
  • Continue pagination using the last project's immutable result while preserving caller-supplied order for targeted project requests.

Why:

  • Surface the most broken projects first without adding severity data to continuation tokens or introducing compatibility handling.

Test Plan

  • Add unit tests.
  • Verify pagination against a real database and through the service API.

Revert Plan

  • Revert this PR. No schema migration or persisted-data change is involved.

Issue Links

@prathshenoy
prathshenoy force-pushed the feat/stovepipe-degree-order branch from 38ee0d7 to 4833752 Compare October 21, 2026 13:04
@prathshenoy
prathshenoy marked this pull request as draft October 21, 2026 14:58
mnoah1
mnoah1 reviewed Oct 21, 2026
View reviewed changes
Comment thread stovepipe/extension/storage/mysql/validation_fact_store.go
}

query += ` ORDER BY degree DESC, project ASC LIMIT ?`
args = append(args, limit)

@mnoah1 mnoah1 Oct 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the lookup here more key-value based: Get the matching requests, then sort them in the response. If necessary, we could do a separate "broken projects" lookup table that serves as an index to easily get the IDs of the broken ones.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnoah1 mnoah1 mnoah1 left review comments
@behinddwalls behinddwalls Awaiting requested review from behinddwalls behinddwalls is a code owner
@sbalabanov sbalabanov Awaiting requested review from sbalabanov sbalabanov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prathshenoy @mnoah1