Skip to content

feat(web): adopt BaseUI with host-owned theming - #888

Merged
mnoah1 merged 1 commit into
mainfrom
mnoah1/web-baseui
Oct 21, 2026
Merged

mnoah1 merged 1 commit into
mainfrom
mnoah1/web-baseui

Conversation

@mnoah1

@mnoah1 mnoah1 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Replace native controls and tables in the SubmitQueue and Stovepipe views with BaseUI. Hosts own providers, themes, and Styletron SSR/hydration; BaseUI and Styletron React are peers.

Use BaseUI props for full-width layout with small gutters and responsive behavior. The stylesheets retain only one rule for wrapping long identifiers and errors; scrolling tables support keyboard access.

Preserve gateway-owned pagination without a host cursor secret and the paginated project-results UI. Keep filter accessibility attributes valid when menus close and reopen.

Keep SubmitQueue and Stovepipe request details separated into readable rows, align metadata, and show an active view indicator and compact lifecycle trail. Browser regression checks cover spacing, separators, lifecycle placement, mobile overflow, and Stovepipe styling before hydration.

Test Plan

  • All 33 targets passed: ./tool/bazel test //web:check //web/test/e2e/stovepipe:web_test //web/test/e2e/submitqueue:web_test --test_env=SKIP_CLEANUP=false --test_output=errors
  • make fmt lint check-tidy check-gazelle
  • React 18 server rendering and hydration under light, dark, and custom host themes, including project results; browser filtering with mouse and keyboard plus accessibility checks.
  • Run locally: make local-stovepipe-web-start, then open the printed URL (credentials: test/test).

Revert Plan

Revert this migration and roll back consumer package updates together; no stored-data migration is involved.

Issue Links

None; this change updates frontend presentation and host integration.

@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners October 19, 2026 19:24
@mnoah1
mnoah1 force-pushed the mnoah1/web-baseui branch 3 times, most recently from ba1e49f to 20fd875 Compare October 19, 2026 20:16
@mnoah1
mnoah1 force-pushed the mnoah1/web-baseui branch 2 times, most recently from a3f04e7 to b2acd5b Compare October 21, 2026 15:04
Use BaseUI directly in SubmitQueue and Stovepipe views, with host-owned themes,
providers, and Styletron SSR/hydration. Preserve gateway-owned pagination and
project results, and correct filter accessibility for mouse and keyboard use.

Validated all 33 web checks and production browser targets, plus repository
formatting and dependency checks. React 18 packages hydrate under light, dark,
and custom host themes.

Co-Authored-By: Preetam Dwivedi <preetam@uber.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@mnoah1
mnoah1 force-pushed the mnoah1/web-baseui branch from b2acd5b to 20c18cd Compare October 21, 2026 15:09
@mnoah1
mnoah1 enabled auto-merge October 21, 2026 15:13
@mnoah1
mnoah1 added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit 294257b Oct 21, 2026
20 checks passed
@mnoah1
mnoah1 deleted the mnoah1/web-baseui branch October 21, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants