Repository navigation
fix(web): typescript config - resolve library types without host compiler overrides - #869
Merged
Merged
Conversation
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 14, 2026 20:11
mnoah1
enabled auto-merge
October 14, 2026 20:14
mnoah1
changed the title
prathshenoy
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The web libraries expose their declarations through
exports. TypeScript's legacynoderesolver does not read that field, so hosts using it cannot resolve the public imports without changing their compiler configuration.Change
Add a top-level
typesentry and explicittypesVersionsmappings for the public JavaScript subpaths in platform, Stovepipe, and SubmitQueue. Keep the existing exports, ESM output, and browser/server boundaries unchanged. This adds declaration resolution support, not CommonJS support.Use the same packaged consumer fixture to check every public JavaScript entry point with both
nodeandbundlerresolution. Run the new legacy-resolver check in the normal web test suite.Test plan
make web-check(includes both consumer typechecks, package contents, Node runtime, and React 18 rendering checks)make fmt,make lint,make check-tidy,make check-gazelle