Skip to content

feat(gateway): Reject land requests for a paused queue - #864

Merged
manjari25 merged 5 commits into
manjari/queue-pause-2-storesfrom
manjari/queue-pause-3-gateway-reject
Oct 15, 2026
Merged

manjari25 merged 5 commits into
manjari/queue-pause-2-storesfrom
manjari/queue-pause-3-gateway-reject

Conversation

@manjari25

Copy link
Copy Markdown
Contributor

Why?

A paused queue must stop accepting new work. Rejecting at the gateway, before a request ID is minted, means a refused land consumes no sequence number and writes nothing.

What?

  • Land() reads the queue's pause state after the queue lookup and before storage and the counter. A queue with RejectLands set returns QueuePausedError, a non-retryable user error that the gRPC layer maps to FailedPrecondition, so callers can tell it from a bad request or an unknown queue.
  • A failed pause read fails the land, so an unreadable pause state can't let a paused queue accept work.
  • The gateway reads the file named by QUEUE_PAUSE_CONFIG_PATH, and pauses nothing when it is unset. A bad path fails at startup.

freeze_processing is read but not enforced yet. Freezing processing follows in a later PR.

Test Plan

bazel test //submitqueue/gateway/controller/... //service/submitqueue/gateway/server/...
CI

Issue

@manjari25
manjari25 requested review from a team, behinddwalls and sbalabanov as code owners October 14, 2026 17:39
@behinddwalls
behinddwalls added this pull request to stack #868 October 14, 2026 19:49
@manjari25
manjari25 force-pushed the manjari/queue-pause-3-gateway-reject branch from f32a29d to a051964 Compare October 14, 2026 20:31
@behinddwalls
behinddwalls added this pull request to the merge queue Oct 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 15, 2026
@manjari25
manjari25 added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit c3f3bc6 Oct 15, 2026
19 checks passed
@manjari25
manjari25 deleted the manjari/queue-pause-3-gateway-reject branch October 15, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants