Skip to content

feat(submitqueue): Add noop, file, fake queuepause store - #863

Merged
manjari25 merged 4 commits into
manjari/queue-pause-1-contractfrom
manjari/queue-pause-2-stores
Oct 15, 2026
Merged

manjari25 merged 4 commits into
manjari/queue-pause-1-contractfrom
manjari/queue-pause-2-stores

Conversation

@manjari25

@manjari25 manjari25 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Why?

The queuepause.Store contract needs OSS implementations so a queue can be paused without a custom backend. Deployers can still supply their own store.

What?

  • noop: never pauses a queue. It is the default when nothing is configured.
  • file: reads a YAML list of queues with reject_lands and freeze_processing, and re-reads it on every Get, so editing the file pauses or unpauses a queue with no restart.
    • The file must exist and parse at construction, so a mistyped path fails at startup.
    • A later read or parse failure is returned as an error, never treated as not paused.
    • Unknown fields, empty names and duplicate names are errors, so a misspelled switch can't leave a queue unpaused.
  • fake: an in-memory store for tests. A test sets a queue's state, changes it while consumers run, and can make every read fail. It is never used in production.

Nothing consumes these stores yet. The gateway wiring follows in the next PR

Test Plan

bazel test //submitqueue/extension/queuepause/...
CI

Issue

@manjari25
manjari25 requested review from a team, behinddwalls and sbalabanov as code owners October 14, 2026 17:38
@behinddwalls
behinddwalls added this pull request to stack #868 October 14, 2026 19:49
Comment thread submitqueue/extension/queuepause/noop/noop.go
@manjari25
manjari25 force-pushed the manjari/queue-pause-2-stores branch from d39ccab to 76bc41b Compare October 14, 2026 20:25
@manjari25 manjari25 changed the title feat(submitqueue): Add noop and file queuepause store feat(submitqueue): Add noop, file, fake queuepause store Oct 14, 2026
@behinddwalls
behinddwalls added this pull request to the merge queue Oct 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 15, 2026
@manjari25
manjari25 added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit 5c83a2a Oct 15, 2026
33 of 35 checks passed
@manjari25
manjari25 deleted the manjari/queue-pause-2-stores branch October 15, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants