Repository navigation
ci: skip live GitHub tests on Dependabot runs - #861
Closed
behinddwalls wants to merge 1 commit into
Closed
behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
## Summary ### Why? Dependabot-triggered workflows only receive Dependabot secrets, so `SQ_TEST_REPO_TOKEN` is empty. The same-repo check still set `SQ_GITHUB_TEST_REQUIRED=true`, failing the merger and e2e jobs on every Dependabot PR (e.g. #853). ### What? - Treat `github.actor == 'dependabot[bot]'` like a fork PR: the live GitHub tests skip instead of failing. ## Test Plan - ✅ Workflow YAML parses; `githubtestrepo.New` skips when the token is empty and the required flag is false. - Post-merge: `@dependabot rebase` on #853 and confirm the Merger Extension Test passes (skipped live cases).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
Dependabot-triggered workflows only receive Dependabot secrets, so
SQ_TEST_REPO_TOKENis empty. The same-repo check still setSQ_GITHUB_TEST_REQUIRED=true, failing the merger and e2e jobs on every Dependabot PR (e.g. #853).What?
github.actor == 'dependabot[bot]'like a fork PR: the live GitHub tests skip instead of failing.Test Plan
githubtestrepo.Newskips when the token is empty and the required flag is false.@dependabot rebaseon build(deps-dev): bump vitest from 4.0.7 to 4.1.11 in /web/platform #853 and confirm the Merger Extension Test passes (skipped live cases).