Repository navigation
fix(sensor): do not report deleted Codex rollouts as stat failures - #212
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Codex state catalogs (state_*.sqlite) keep thread rows after their rollout file is deleted. Each such row was counted as file_stat_error, so a normal Codex install reported its parse health as "partial" on every run. A missing catalog target is now skipped like other missing optional inputs; permission and other stat failures are still reported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
Catch FileNotFoundError first and skip the candidate silently (same treatment the parser already gives a missing optional catalog, and Cline/Gemini give missing optional files). PermissionError and other stat failures still count.
Why?
Codex's state catalog (~/.codex/state_5.sqlite,
threads.rollout_path) keeps rows after the rollout file is deleted. CodexParser._add_rollout_candidate (Sensor/adr_sensor/parsers/codex_parser.py:149) stats each catalog path and counts FileNotFoundError asfile_stat_error, a non-expected diagnostic code, so diagnostics.health_record marks the codex parse stage "partial" (and writes it to error.log) on every run. On this machine 432 of 1721 catalog rows point at deleted files: a real run printed{'file_stat_error': 432, 'file_age_skipped': 694}.How did you test it?
tests/test_parser_diagnostics.py::test_codex_catalog_row_for_deleted_rollout_is_not_a_stat_failure(catalog row -> nonexistent .jsonl; expects no candidates and no diagnostics). main: FAILED ({'file_stat_error': 1}); branch: passed. Existingtest_stat_failure_is_not_reported_as_age_filtering(PermissionError -> file_stat_error) still passes. Real data:CodexParser(max_age_days=7).parse_all()diagnostics main{'file_stat_error': 432, 'file_age_skipped': 694}-> branch{'file_age_skipped': 694}, same 546 sessions..venv/bin/python -m pytest tests/ -q(py3.14) 609 passed.Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.