Repository navigation
fix(discovery): count symlinked skill and plugin directories - #205
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Directory listings report is_dir without following links, so a skill linked into place (`ln -s ~/src/review ~/.claude/skills/review`) failed the membership test and never became a declaration, although the host loads it and gate.hash_tree already hashes a root reached through a link. Accept symlinks as candidate members; the existing manifest check still drops links to files and dangling links. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
Accept
entry.is_symlinkas a candidate member too; the existing_manifest_ofcheck drops links to files and dangling links.Why?
Extractor/surfaces.py:86-87
_is_memberrequiresentry.is_dirfor nested surfaces, but gate.list_dir sets is_dir with follow_symlinks=False. A skill linked into place (~/.claude/skills/review -> ~/src/review) is never a declaration, so it is missing from the inventory, although gate.hash_tree explicitly supports roots reached through a link (test_folder_hash.test_a_root_reached_through_a_link_hashes_its_target).How did you test it?
uv run --python 3.11 pytest -q adr_discovery/tests_unit/test_m3_surfaces.py-> main: 1 failed (only "other" found), 8 passed; branch: 9 passed. Pipeline probe on branch: linked skill becomes a skill asset at ~/.claude/skills/review with skill_sha256.pytest -q561 passed;ruff check .clean.Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.