Repository navigation
fix(discovery): skip bracketed argument-hint instead of failing the command - #204
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
…ommand Claude Code documents slash-command hints as `argument-hint: [pr-number] [priority] [assignee]`. The frontmatter reader sent every `[`-led value to the flow-list parser, which raised Unrepresentable on the second `[`, so the whole command file became an ExtractError and dropped out of the inventory. Non-list keys never use the flow items (a single `[message]` was already skipped), so skip them before parsing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
Return _SKIP for a
[-led value of a non-list key before parsing (the items were already discarded for non-list keys).Why?
Extractor/formats/frontmatter.py:155-158 sends any
[-led value to _flow_items, even for non-list keys.argument-hint: [pr-number] [priority] [assignee](the form in Claude Code's slash-command docs) raises Unrepresentable("nested collection in flow list"); surfaces._declaration only catches NoFrontmatter, so the command becomes an ExtractError and is missing from the inventory.How did you test it?
uv run --python 3.11 pytest -q adr_discovery/tests_unit/test_frontmatter_tolerance.py-> main: 2 failed, 21 passed; branch: 23 passed.pytest -q562 passed;ruff check .clean.Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.