Repository navigation
fix(detection): skip raw AgentDojo run dirs when packing a benchmark - #202
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
An AgentDojo run directory holds the converted task_NNN directories next to the raw task_NNN_agentdojo_run output directories. deflate matched every task_* directory, so it packed the raw ones as tasks with a null conversation and result and doubled task_count. The shipped agentdojo_20251022_190150.jsonl shows it: task_count 186, of which 93 records are empty *_agentdojo_run entries. main_detector already skips these directories; deflate now does the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
Exclude names ending in
_agentdojo_run, the same filter main_detector uses. Regression test added in tests/test_benchmark_pack.py.Why?
In benchmark/benchmark_pack.py cmd_deflate, task discovery used
name.startswith("task_"), so an AgentDojo run dir also packed the rawtask_NNN_agentdojo_rundirs as task records with null conversation/result and doubled task_count. The shipped benchmark/agentdojo_20251022_190150.jsonl proves it: task_count 186, of which 93 are empty*_agentdojo_runrecords (93 real). main_detector.py:81 already excludes these dirs.How did you test it?
pytest tests/test_benchmark_pack.py. On main: the new test fails (task_count 2, records task_001 and task_001_agentdojo_run). On the branch: 5 passed.*_agentdojo_run/workspacedirs, which the detector ignores).Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.