Repository navigation
fix(sensor): percent-encode the opencode database URI - #200
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
The opencode parser opened its database with f"file:{path}?mode=ro" and
uri=True without escaping the path. A data directory containing '#', '?'
or '%' made SQLite read a different path: the database was never found,
and with '#' the "?mode=ro" suffix was cut off so SQLite created an empty
stray file next to the real directory. Build the URI with Path.as_uri(),
as the Codex parser already does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
Build the URI with
Path(db_path).resolve().as_uri() + "?mode=ro"(same as CodexParser), via a small_read_only_urihelper used in both places.Why?
Sensor/adr_sensor/parsers/opencode_parser.py:163 and :227 open
sqlite3.connect(f"file:{db_path}?mode=ro", uri=True)without escaping. If the data dir path (e.g. $XDG_DATA_HOME or home) contains '#', '?' or '%', SQLite reads another path: opencode history is never found (backend None, 0 events), and with '#' the?mode=rois cut off so SQLite creates an empty stray file (e.g..../datanext to.../data#1).How did you test it?
data#1 None 0 ['data', 'data#1']and100%data None 0; branch ->data#1 sqlite 1 ['data#1'],100%data sqlite 1. New parametrized testtest_reads_database_under_path_with_uri_special_characters(#, %, ?): main 3 failed; branch 3 passed.Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.