Repository navigation
fix(sensor): parse ISO timestamps with any fractional-second precision - #198
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
On Python 3.9 and 3.10, datetime.fromisoformat() only accepts exactly 3 or 6 fractional-second digits, so normalize_timestamp() raised on RFC 3339 values such as "2025-07-16T13:32:09.12345Z" or nanosecond timestamps (Go's RFC3339Nano). Parsers then dropped the event time and fell back to file mtimes. Pad or truncate the fraction to microseconds before parsing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
Before fromisoformat, pad/truncate the fractional-seconds group (only when it follows
:SS) to 6 digits. No behavior change on 3.11+.Why?
Sensor/adr_sensor/utils/timestamp_utils.py:31 calls datetime.fromisoformat(), which on Python 3.9/3.10 (both in the CI matrix, requires-python >=3.9) only accepts exactly 3 or 6 fractional digits.
normalize_timestamp("2025-07-16T13:32:09.12345Z")or a nanosecond value ("...09.123456789Z", what Go's RFC3339Nano / protojson emit) raises ValueError("Unable to parse timestamp"). Every parser routes event times through this helper, so those events lose their timestamp (fall back to file mtime / now,invalid_timestampdiagnostics).How did you test it?
uv run --python 3.9 python -c 'from adr_sensor.utils.timestamp_utils import normalize_timestamp as n; n("2025-07-16T13:32:09.12345Z")'-> main: ValueError; branch: 2025-07-16 13:32:09.123450+00:00. New testtests/test_utils.py::TestNormalizeTimestamp::test_iso_string_with_any_fraction_length(5 cases): py3.9 on main 5 failed; on branch 26/26 pass in test_utils.py.Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.