Repository navigation
fix(discovery): run the README commands from the Discovery directory - #197
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
adr_discovery/README.md said to run `uv run adr-discovery` from the repository root, where there is no pyproject.toml and uv fails with "Failed to spawn: adr-discovery". The script is defined in Discovery/pyproject.toml, as Discovery/README.md already says. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
Say "From the
Discoverydirectory".Why?
Discovery/adr_discovery/README.md:33 says "From the repository root:" then
uv run adr-discovery ...; at the repo root uv fails:error: Failed to spawn: adr-discovery.How did you test it?
cd <repo root> && uv run adr-discovery --help-> Failed to spawn;cd Discovery && uv run adr-discovery --help-> usage.Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.