Repository navigation
fix(sensor): create missing parent directories for --output-dir - #192
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
`adr-sensor --output-dir out/nested/dir` crashed with FileNotFoundError when the parent directories did not exist yet: AgentObserver.__init__ and save_to_file created the output directory without parents=True, even though the diagnostics, session and runtime-log writers already do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
Use
mkdir(parents=True, exist_ok=True)in both places (diagnostics/session/runtime-log writers already do).Why?
adr-sensor --source gemini --output-dir /tmp/x/a/b/c(parents missing) -> tracebackFileNotFoundErrorfromAgentObserver.__init__(Sensor/adr_sensor/observer.py:109self.output_dir.mkdir(exist_ok=True));save_to_file(observer.py:314) has the same issue for library callers.How did you test it?
uv run pytest tests/test_observer.py -q -k nested-> main (source reverted): 2 failed; branch: 2 passed. Manual CLI run on main reproduced the FileNotFoundError traceback.uv sync --extra dev && uv run pytest tests/ -q-> 610 passed (608 on main + 2 new).ruff checkhas one pre-existing I001 in tests/test_utils.py (also on main); changed files passruff format --check.Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.