Repository navigation
Refactor the project - #213
Merged
Merged
Conversation
Khabib73
marked this pull request as draft
October 28, 2026 20:10
sobolevn
reviewed
Oct 29, 2026
| except TypecheckAssertionError: | ||
| if not self.expect_fail: | ||
| raise e | ||
| raise TypecheckAssertionError |
Member
There was a problem hiding this comment.
Suggested change
| raise TypecheckAssertionError | |
| raise |
| "pytest>=7.0.0", | ||
| "pyyaml", | ||
| "regex", | ||
| # TODO: should we use tomli? |
Contributor
Author
There was a problem hiding this comment.
Thanks! Ok, I also a little scale project, I create new dir logic, into I add pure functions, it's more seems good pattern for others project like dotenv-linter and wps.
Khabib73
marked this pull request as ready for review
October 30, 2026 08:09
Contributor
Author
|
Improve architecrutre, now we use
|
sobolevn
reviewed
Oct 30, 2026
| from typing import Any, Final | ||
|
|
||
| import tomlkit | ||
| import tomli |
Member
There was a problem hiding this comment.
oh, right. sorry, this was my mistake. we should not do that.
new deps are not really required here. let's keep this as it was.
Contributor
Author
There was a problem hiding this comment.
That’s even better!
Contributor
Author
|
prepare to add wps 🥰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.