Repository navigation
Conversation
nertwork
force-pushed
the
fix/87-numpad-input
branch
3 times, most recently
from
November 15, 2026 00:36
744e960 to
b9825d3
Compare
…, and Wayland scan codes Resolve printable numpad characters in LauncherWindow.typedText(event) when Qt sets Qt.KeypadModifier, when Qt/Wayland reports numpad keys with navigation keysyms (Insert/End/Down/PageDown/Left/Clear/Right/Home/Up/PageUp/Delete) and empty event.text, or via XKB keypad nativeScanCode (evdev + 8), while guarding list direction() and PageUp/PageDown from hijacking numpad 8/2/9/3 and preserving Enter and Ctrl/Alt/Meta shortcuts. Fixes typecraft-dev#87
Author
|
Hey @cpow — first off, huge thanks for building oma-cast! It is genuinely an awesome launcher and a massive upgrade to my daily Omarchy / Hyprland workflow (the Quickshell UI, built-in calculator/currency conversion, and script commands are super clean and fast). Just rebased this PR cleanly onto the latest |
nertwork
force-pushed
the
fix/87-numpad-input
branch
from
November 17, 2026 22:18
b9825d3 to
2342b7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Qt.KeypadModifier(0x20000000) inLauncherWindow.isTyping(event)(ui/LauncherWindow.qml) before comparing modifiers againstQt.NoModifier/Qt.ShiftModifier.0–9), operators (+,-,*,/,=), and decimal separators (./,) across:handleKey)handleArgumentKey)handlePopupKey)Qt.Key_Enteractivation andCtrl/Alt/Metakeypad shortcuts (Ctrl+1..9,Ctrl++,Ctrl+-,Ctrl+0).tests/launcher-numpad.test.jsexecuting the QML handlers directly in Nodevmcontext.Fixes #87
Test Plan
node --test tests/*.test.js(144 passed, 0 failed)git diff --check