Skip to content

Show the launcher on outputs scaled below 1 - #101

Open
Popoch39 wants to merge 1 commit into
typecraft-dev:mainfrom
Popoch39:fix/overlay-scale-below-1
Open

Popoch39 wants to merge 1 commit into
typecraft-dev:mainfrom
Popoch39:fix/overlay-scale-below-1

Conversation

@Popoch39

Copy link
Copy Markdown

Generated by Claude (Claude Code): diagnosis, fix, test and this description.

Summary

On an output scaled below 1, the launcher maps and grabs the keyboard but never draws: Qt keeps devicePixelRatio at 1 while Hyprland reports the real scale, so contentReady never holds.

 contentReady =
   shown && screen && targetMonitor
   && size == screen size
-  && dpr * 120 == scale * 120
+  && dpr * 120 == max(1, scale) * 120

Evidence

Logged on a 1920x1080 HDMI output at scale 0.8 (Omarchy 4.5, Hyprland 0.56), 500 ms after omacast:toggle:

shown=true screen=HDMI-A-1 size=2400x1350 screenSize=2400x1350 devicePixelRatio=1 monitor.scale=0.8

The same log on the 1.6 laptop panel reads devicePixelRatio=1.6 monitor.scale=1.6, and it opens there.

New tests/content-ready.test.js evaluates the contentReady binding from ui/LauncherWindow.qml in node:

scale 1.6, dpr 1     -> hidden
scale 1.6, dpr 1.6   -> shown
scale 0.8, dpr 1     -> shown
width != screen size -> hidden
  • Before: ✖ content is revealed on an output scaled below 1 (pass 2, fail 1)
    After: node --test tests/*.test.js: 187 pass, 0 fail, 3 skipped (live QML runner); omarchy plugin validate . passes.

Merge Danger

Door: two-way

One expression in a binding; reverting the commit restores the old behaviour.

Blast Radius: sub-1x outputs

Outputs at scale ≥ 1 compute exactly as before. On outputs below 1 the card is now revealed instead of staying transparent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant